Repository navigation
improvement(computer-use): wait for an app's first observable window after launching it - #10112
Merged
waleedlatif1 merged 2 commits intoNov 17, 2026
Merged
Conversation
…after launching it
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThe PR waits longer after launching an app and checks that an Accessibility window matches an entry in the app’s window list.
Reviews (2) · Last reviewed commit: "count a minimized window as ready and ti..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_app_statelaunches an app, the helper waited at most 2 s for any Accessibility window. Electron and Catalyst apps (Obsidian, VS Code, Preview) take longer, so the first read failed withapp_window_unavailableand the agent had to repeat it; VS Code also failed after its AX window existed but before its frame matched an on-screen windowget_app_stateuses to list windows. It stays cancellable and still stops if the app exits; an app that never opens a window now fails after 8 s instead of 2 sType of Change
Testing
get_app_state, no model calls): current staging failed both Obsidian and VS Code withapp_window_unavailableafter about 3.5–4 s; this branch read both on the first call (4.7 s and 3.9 s cold)Checklist