Repository navigation
fix(computer-use): treat an attribute-unsupported refusal of an advertised action as unsupported - #10109
Conversation
…tised action as unsupported
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge. SummaryThe PR reports
No actionable issues were found. No previous review threads were supplied. Native tests were not run during this review. Reviews (2) · Last reviewed commit: "scope the refusal mapping to performed a..." · Reviewed by Greptile |
…rites keep the generic error
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
unsupported_action, but only forkAXErrorActionUnsupported(-25206). Finder and file-panel cells refuseAXOpenwithkAXErrorAttributeUnsupported(-25205), so they still surfaced the generic "observe the app again" error (confirmed with a Finder probe in a macOS VM)dispatchAXnow treats -25205 the same way. It was already in the not-dispatched set, so the snapshot stays valid; only the error code and message change, pointing to another advertised action or a click (clickCount: 2opens most files and folders)Type of Change
Testing
accessibility_error-25205 telling the agent to observe again; this branch,unsupported_actionwithdispatchState: not_startedand the snapshot still valid, then a double-click on that same snapshot opens DownloadsChecklist