Skip to content

fix(computer-use): treat an attribute-unsupported refusal of an advertised action as unsupported - #10109

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/computer-use-attribute-unsupported-refusal
Nov 17, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/computer-use-attribute-unsupported-refusal

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • improvement(computer-use): report an advertised action the element refuses as unsupported, with the snapshot still valid #10106 mapped an advertised-but-refused action to unsupported_action, but only for kAXErrorActionUnsupported (-25206). Finder and file-panel cells refuse AXOpen with kAXErrorAttributeUnsupported (-25205), so they still surfaced the generic "observe the app again" error (confirmed with a Finder probe in a macOS VM)
  • dispatchAX now treats -25205 the same way. It was already in the not-dispatched set, so the snapshot stays valid; only the error code and message change, pointing to another advertised action or a click (clickCount: 2 opens most files and folders)

Type of Change

  • Bug fix

Testing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 17, 2026 2:11am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The PR reports unsupported_action when an advertised Accessibility action returns .attributeUnsupported or .actionUnsupported.

  • Refused advertised actions now point callers to another action or a click.

No actionable issues were found. No previous review threads were supplied. Native tests were not run during this review.

Reviews (2) · Last reviewed commit: "scope the refusal mapping to performed a..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit cbb3d5e into staging Nov 17, 2026
49 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/computer-use-attribute-unsupported-refusal branch November 17, 2026 02:13

This branch was previously deployed

1 inactive deployment
Preview — 5113ca84 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant