Repository navigation
feat(search): add GitLab group sources with per-project permissions - #10107
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[High impact] The PR appears safe to merge; no actionable new defects were identified. SummaryAdds GitLab group sources to Search while keeping ordinary knowledge-base ingestion project-scoped.
No actionable new findings were identified. No previous review threads were supplied. Review checks were based on source code; tests were not run.
|
There was a problem hiding this comment.
All reported issues were addressed across 28 files
This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 34 files
Confidence score: 4/5
- In
apps/sim/connectors/gitlab/gitlab.ts, group validation trusts the saved scope, so access updates can succeed with a revoked token or a moved group. Revalidate the current token and group identity when saving.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/connectors/gitlab/gitlab.ts">
<violation number="1" location="apps/sim/connectors/gitlab/gitlab.ts:1347">
P2: Group validation accepts the saved scope without revalidating the current GitLab token or group identity. Saving group settings through the access-update path can therefore succeed with a revoked token or moved group, leaving the source broken until a later sync/search; re-run bounded group discovery with `accessToken` before returning success.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
c52bb1c to
accb5bb
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 38 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
Product update
Admins can connect a GitLab group once instead of adding each project. Search remains live and only searches projects allowed for the current user. Create group sources after the app deployment completes; existing project sources and CI jobs continue unchanged. GitLab setup guide
Type of Change
Testing
Checklist