Skip to content

fix(people): answer the cookie consent card in the people e2e so it can't block mobile taps - #10101

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/people-e2e-cookie-banner
Nov 16, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/people-e2e-cookie-banner

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The People E2E browser check failed on its phone-width pass: the cookie consent card docks bottom-left at up to 380px wide, so on a 390px viewport it sits over the org chart's "Next reports" control and every tap on it hit the card instead
  • The card shows only where the visitor's jurisdiction asks for consent and only after the page loads, so whether it appeared in a given run varied
  • Each browser page in the check now registers a Playwright locator handler that answers the card (Reject all, or Accept all where that is the only choice) whenever it appears, the way a visitor would, before any action it would otherwise block
  • No product change: the card stays non-modal by design

Type of Change

  • Bug fix

Testing

  • biome check on the script
  • The People E2E (test:people:e2e with PEOPLE_E2E_SCREENSHOT_DIR) runs in this PR's e2e CI job, which exercises the desktop, empty-state, mobile (390px and 320px) and outsider pages that now register the handler

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 16, 2026 10:23pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The People browser check now answers the cookie consent card before it can block an action.

  • People browser checks answer the cookie card when it appears.

No actionable issues found. The browser check was not run during this review.

Reviews (1) · Last reviewed commit: "fix(people): answer the cookie consent c..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a166e33 into staging Nov 16, 2026
146 of 149 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/people-e2e-cookie-banner branch November 16, 2026 22:54

This branch was previously deployed

1 inactive deployment
Preview — 93a79ae2 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant