rust(feat): generic artifact store tools - #779
Draft
evan-sift wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the artifact MCP tools for the generic artifact store exposed by
sift.artifacts.v1.artifacts.proto(storage class, created-via surface, kind, JSON payload, metadata, links, CELfilterandorder_by, link RPCs) and regenerates the Rust bindings.list_artifactsacceptsfilter(CEL) andorder_by, and documents the filterable fields, enum comparisons,links.exists(...)andmetadata["<key>"]forms. Results are scoped to the caller's organization.create_artifactacceptskind,storage_class(file|structured|blob),created_via(chat|canvas|sdk|upload), a structured JSONpayload,metadata, andlinks. Local validation rejects payload/storage-class mismatches before any request. Omitted container fields stay unset on append so existing artifacts keep their class.download_artifactdocuments that structured artifacts carry their payload inline.Existing callers of
list_artifacts,create_artifact, anddownload_artifactkeep working unchanged.Depends on the matching server change to
sift.artifacts.v1landing first; against an older server the new create parameters are ignored andfilter/order_byare unsupported.Verification
cargo fmt --all -- --checkcargo clippy --all-features -p sift_mcp -p sift_test_util(only the pre-existingtoo_many_argumentswarning inservice/report_templates)cargo test -p sift_mcp -p sift_test_util: 524 + 6 passed