Skip to content

fix(windows): support background task cancellation - #111

Open
pj991207 wants to merge 1 commit into
sendbird:mainfrom
pj991207:fix/windows-process-identity
Open

pj991207 wants to merge 1 commit into
sendbird:mainfrom
pj991207:fix/windows-process-identity

Conversation

@pj991207

Copy link
Copy Markdown

Closes #110

Summary

  • use the Windows process start time as the stored PID identity
  • route Windows cancellation through the existing process-tree termination helper
  • make the process tests portable and include them in the Windows CI suite

Verification

  • npm run test:cross-platform (299 passed)
  • npm run lint
  • npm run typecheck
  • npm run check:version-sync
  • npm run check:changelog
  • launched a real background companion job on Windows and confirmed cancellation removed the claude.exe, Bash, and Node process tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: background job cancellation fails without a process identity

1 participant