Repository navigation
Use NeuralAmpModelerCore for the cabinet slot instead of separate impulse response code - #688
Merged
Merged
Conversation
Load WAV and NAM cabs through ResamplingNAM. Preserve legacy WAV playback levels and use NAM cabs' stored levels. Update Core to include Linear prewarming fixes. Report both slots' prewarm lengths plus two seconds for the DC blocker, and update latency, tail, and output gain when bypassing or replacing the cab. Rename cab-related identifiers and add regression coverage while preserving saved-session compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the old AudioDSPTools code for cabs with NeuralAmpModelerCore, since "impulse responses" are really just linear models, which are a just a special kind of NAM.
This also allows for using different model architectures as cab models if one wishes (so long as they are NAMs, of course--which basically anything can be).
There's a bit of trickiness to maintain some nice things like the -18 dB level reduction that's applied .wav files that represent cab models. It could have been done by hot-rodding the "load dsp" routine, but I'd rather not see that get made more complex.
I was also a little bit suspicious about some of the leveling code, so I did test it with a couple different host sample rates and verified manually that the loudness of the cab isn't affected.
Closes #685.
PR Checklist
format.bash?Unserialization.cpp.)