feat: real container restart remediation via argus-executor - #7
Merged
Merged
Conversation
- Add dedicated argus-executor service that owns /var/run/docker.sock - execute_runbook_step no longer accepts a command string; it looks up typed runbook steps and routes restart through the executor - Enforce per-incident remediation attempt cap (default 3, env configurable) - Keep /recover endpoints for manual/demo reset but remove from agent path - Refuse execution in native modes where no executor is configured - Document all seven demo scenarios including the unprimed api-oom case - Add remediation-cap test and update approval-gate test for new tool signature
sdOps
added
enhancement
…ting After execute_runbook_step reports back (incident.status = mitigated), the UI should display 'verifying' while it waits for the detection path to clear the remaining firing alerts, instead of staying in 'executing'. Update the workflow state machine test to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified:
This is a large change because it adds the executor service, refactors the remediation tool, and updates docs across both README.md and ARCHITECTURE.md.
Closes #6