📦 Ship the complete test tree and its resources in the sdist - #616
Merged
Conversation
The sdist only contained the four top-level `test*.py` files that setuptools picks up by default: `tests/resources/` and the `splitter_tests` and `middleware_tests` subpackages were missing, so running the test suite from an unpacked sdist failed with `FileNotFoundError: tests/resources/gbk_test.bib`. Add a `MANIFEST.in` grafting `tests`. The wheel is unaffected, as `[tool.setuptools.packages.find]` restricts it to `bibtexparser*`. Fixes #486 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sdist only shipped the four top-level
test*.pyfiles that setuptools picks up by default.tests/resources/and thesplitter_tests/middleware_testssubpackages were missing, so running the suite from an unpacked sdist failed withFileNotFoundError: tests/resources/gbk_test.bib.Fix: add a
MANIFEST.inthat graftstests(with aglobal-excludefor__pycache__/*.pycso stale caches do not leak in).Verified:
pytest -qin an unpacked sdist: 2730 passed, 12 skipped — identical to a checkout.[tool.setuptools.packages.find]keeps it tobibtexparser*).Fixes #486
🤖 Generated with Claude Code