🔧 Drop dead library parameter from Splitter.split() - #610
Merged
Conversation
Since #603, `parse_string` builds a fresh `Library` and merges the result instead of handing the caller's library to the splitter, so nothing in the package (or the tests, docs or README) passes `library=` to `Splitter.split()` any more. Removing it rather than keeping an unused public parameter, while 2.0.0 is still unreleased (2.0.0b9). `split()` now always returns a new `Library`; the `Splitter` class and `split()` itself stay public. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
lgtm |
MiWeiss
force-pushed
the
chore/drop-splitter-split-library-param
branch
from
September 2, 2026 20:38
febbe96 to
ed1bb24
Compare
…plit-library-param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #603,
parse_stringbuilds a freshLibraryand merges the result instead of passing the caller's library into the splitter. That leftSplitter.split(library=...)with no caller: nothing inbibtexparser/,tests/,docs/, the README or the notebooks passes it.Removed the parameter, so
split()always returns a newLibrary(the deadlogger.info("Adding blocks to existing library.")branch goes with it). Breaking change to a public signature, which seems right to take now while 2.0.0 is unreleased (2.0.0b9, #609).Splitterandsplit()stay public and unrenamed; no test calledsplit(library=...), so no test changes.Merges cleanly with both #598 and #602 — I trial-merged each; #598 touches the adjacent mark regex but does not conflict.
2589 passed, 12 skipped.
🤖 Generated with Claude Code