Support Float16Array - #49
Merged
Merged
Conversation
Contributor
Author
|
@mikolalysenko : Hopefully not too annoying to get a PR after 7 years-it is a useful package! |
Member
|
Maybe add to the docs? https://github.com/scijs/ndarray#arraydtype Otherwise, looks reasonable to me! I think I'm a maintainer and can help get it published, under a new minor version, I think? |
NAThompson
force-pushed
the
float16-support
branch
from
August 24, 2026 20:06
89dff24 to
73d46e2
Compare
Without this a `Float16Array` gets the "generic" dtype, so `.get()` fails with `this.data.get is not a function` -- the same breakage `BigInt64Array` had before 86be8a1.
NAThompson
force-pushed
the
float16-support
branch
from
August 24, 2026 20:06
73d46e2 to
c8b3bba
Compare
Contributor
Author
|
@rreusser : Added one line to the README.md, LMK if you need anything more. |
Member
|
Published as v1.1.1 (minor bump because it's a backward-compatible API change, and not 1.1.0 because that was already published and then deleted 13 years ago). Thanks again! 馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this a
Float16Arraygets the "generic" dtype, so.get()fails withthis.data.get is not a function-- the same breakageBigInt64Arrayhad before 86be8a1.