Repository navigation
ci: take the Go version from go.mod (MK8S-516) - #118
Merged
Merged
Conversation
The pre-merge jobs installed GO_VERSION 1.25, set by hand, while each module declares its Go version in go.mod. A dependency that needs a newer Go (mockery 3.8.1 needs 1.26, #116) bumps the go directive and then fails on every job. Each job now reads the go.mod of the module it checks. Refs: MK8S-516
ezekiel-alexrod
requested review from
anthony-treuillier-scality and
riadelhajjaji-scality
November 2, 2026 22:09
g-carre
approved these changes
Nov 4, 2026
riadelhajjaji-scality
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-merge jobs install Go from
GO_VERSION: 1.25, set by hand, while each module declares its Go version ingo.mod. When a dependency needs a newer Go, Renovate bumps thegodirective and every job fails: #116 (mockery 3.8.1 needs Go 1.26) is red ongo.mod requires go >= 1.26.0 (running go 1.25.14). Each job now reads thego.modof the module it checks.What changes
detect-modulesandbuild-e2eread the rootgo.mod,golangci-lintandtestsread thego.modof their matrix module (root andscenario/).GO_VERSIONand its Renovate annotation go away: thegodirective is the one source, and Renovate already bumps it in the "update golang" PRs. The annotation did not work anyway: on chore(deps): update go module directive to v1.27.1 #63, Renovate only changedgo.mod, andGO_VERSIONhad to be bumped by hand.godirective stays a deliberate choice: the lowest consumer today is the artesca wrapper on Go 1.26.10 (development/4,4.3and5), so chore(deps): update module github.com/vektra/mockery/v3 to v3.8.1 - autoclosed #116 (1.26.0) is fine for them, chore(deps): update go module directive to v1.27.1 #63 (1.27.1) is not.Testing
actionlintubuntu-26.04label it doesn't know yetgo generateclean,make build-e2eOK;scenario/: needsgo mod tidy(its directive follows the root one), then build and tests OKOut of scope
scenario/go.moddirective for chore(deps): update module github.com/vektra/mockery/v3 to v3.8.1 - autoclosed #116: a commit on that PR.go.mod: separate change.Refs: MK8S-516