Skip to content

chore(devcontainer): add a devcontainer (ARTESCA-18391) - #117

Merged
ezekiel-alexrod merged 1 commit into
mainfrom
improvement/ARTESCA-18391-add-devcontainer
Nov 3, 2026
Merged

ezekiel-alexrod merged 1 commit into
mainfrom
improvement/ARTESCA-18391-add-devcontainer

Conversation

@ezekiel-alexrod

Copy link
Copy Markdown
Contributor

This repo has no devcontainer. It gets the same setup as the other Go repos of the team: mcr.microsoft.com/devcontainers/go:1.25-trixie pinned by digest, plus the tools the CI uses.

Review guide

A quick look, it's two small files.

What changes

  • New .devcontainer/ with the Go image and golangci-lint v2.14.0, the CI version.
  • README.md says the devcontainer exists.

Testing

Check Result
docker build .devcontainer OK
Tools in the image go1.25.14, golangci-lint 2.14.0
In the image, repo mounted: go build ./... && go vet ./... OK
docker-in-docker not verified: dockerd does not start on my host, its kernel has no legacy iptable_nat loaded. Same for every devcontainer on docker-in-docker:3, nothing specific to this one.

Out of scope

  • The devcontainers of the other platform repos (nodeip-discovery and file-reflector lag their go.mod, disk-management-agent, metalk8s): separate PRs.

Refs: ARTESCA-18391

Same setup as the other Go repos of the team: devcontainers/go image
pinned by digest, tool versions aligned on the CI.

Refs: ARTESCA-18391
@ezekiel-alexrod
ezekiel-alexrod merged commit c972428 into main Nov 3, 2026
10 checks passed
@ezekiel-alexrod
ezekiel-alexrod deleted the improvement/ARTESCA-18391-add-devcontainer branch November 3, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants