Repository navigation
CLDSRV-1067: UpdateNotificationDestination API - #6368
Open
anurag4DSB wants to merge 2 commits into
Open
anurag4DSB wants to merge 2 commits into
anurag4DSB wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## improvement/CLDSRV-1066-destination-list #6368 +/- ##
============================================================================
+ Coverage 88.28% 88.33% +0.05%
============================================================================
Files 215 216 +1
Lines 14689 14737 +48
============================================================================
+ Hits 12968 13018 +50
+ Misses 1721 1719 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 10, 2026 14:37
8ce9174 to
e89e403
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 10, 2026 15:06
f7de0cf to
1251db1
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 10, 2026 15:06
e89e403 to
cd38b93
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 10, 2026 15:24
1251db1 to
db126da
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 10, 2026 15:26
cd38b93 to
bdef8c0
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 09:52
db126da to
7d0c72c
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 09:52
bdef8c0 to
b3f97de
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 09:53
7d0c72c to
052353d
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 09:53
b3f97de to
24bbad3
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 12:21
052353d to
59ea255
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 12:21
24bbad3 to
47625a9
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 13:06
59ea255 to
15c33ed
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 13:06
47625a9 to
4c9d0b3
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 13:40
anurag4DSB
marked this pull request as draft
November 12, 2026 14:21
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 14:40
15c33ed to
9839ab7
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 14:40
4c9d0b3 to
6509d82
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 15:03
9839ab7 to
1aa7df3
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 15:03
6509d82 to
8a14aef
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 15:19
Add unit tests for the Update handler on the in-memory backend, on a record stored with an old CreatedAt. They check: - the body replaces the whole record: new brokers and topic, defaults applied, and the old Sasl block gone when the body switches to mtls - identity fields and CreatedAt kept as stored, and a new UpdatedAt - a version 1 record written again as version 1 - a record of a newer version refused with InvalidDestination, and left untouched - an IAM user - an unknown name and another account's name: 404 with no write - a bad name, checked before the body - MalformedXML and InvalidDestination (GSSAPI included), with the record kept - the body, checked before the read - store errors - no record value in the logs Add functional tests through Create and Get. They check: - Update 200, then Get shows the new brokers and topic, the old CreatedAt and a later UpdatedAt - an unknown name 404 - an invalid body 400, with the record unchanged - a bad name 400 - anonymous 403 - with a real Vault: an IAM user with no policy gets 403, while a user allowed on one destination updates it and gets 403 on another Each IAM test makes its own IAM user and destinations, and removes the user when it ends.
notificationDestinationUpdate: - checks the name, then checks the body with the checker that Create uses - reads the record of the requester's account. NoSuchDestination stops the update. - writes the whole record again: Type, Connection and Auth from the body, Name, AccountId, Arn and CreatedAt as stored, UpdatedAt now, and the record version that this server writes - leaves a record of a newer version untouched, because it may hold fields that this server would drop. That record gets InvalidDestination, which says to update it from a server that runs the newer version. - answers 200 with no body, and logs the name and the account only - reports its call to the Prometheus metrics, as the bucket APIs do Update writes the record version of the shared request helpers, as Create does.
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 15:58
1aa7df3 to
19b6121
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1067-destination-update
branch
from
November 12, 2026 15:58
8a14aef to
40e765b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://claude.ai/artifact/QhKsCqtGNzaVice35nvip9#bcc30d01-27db.m1yth80jczv.20396
Intent: why does this change exist?
System impact: what's affected, including downstream?
Preserved behavior: what explicitly stays the same?
Name,AccountId,ArnandCreatedAtkeep their stored values.Intended change: what's different after this PR?
UpdatedAt.Verification: how do we know this worked, or how would we know if it didn't?
mem.s3c-ft-testsandfile-ft-testscheck the change through Get.https://claude.ai/code/session_01LSEjuApZSsJxDp6dw1FhVa