Repository navigation
CLDSRV-1066: ListNotificationDestinations API - #6367
Open
anurag4DSB wants to merge 2 commits into
Open
anurag4DSB wants to merge 2 commits into
anurag4DSB wants to merge 2 commits into
Conversation
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 10, 2026 13:56
1548713 to
bdd3517
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 1 file with indirect coverage changes @@ Coverage Diff @@
## improvement/CLDSRV-1065-destination-get #6367 +/- ##
===========================================================================
+ Coverage 88.19% 88.28% +0.08%
===========================================================================
Files 214 215 +1
Lines 14638 14689 +51
===========================================================================
+ Hits 12910 12968 +58
+ Misses 1728 1721 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 10, 2026 13:57
1be2c07 to
f7de0cf
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 10, 2026 15:06
bdd3517 to
16111a8
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
2 times, most recently
from
November 10, 2026 15:24
1251db1 to
db126da
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 09:52
fd93c65 to
8503531
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 09:52
db126da to
7d0c72c
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 09:53
8503531 to
8f59a89
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 09:53
7d0c72c to
052353d
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 12:21
8f59a89 to
be8e241
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 12:21
052353d to
59ea255
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 13:06
be8e241 to
713425b
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 13:06
59ea255 to
15c33ed
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 14:40
713425b to
a7b2f42
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 14:40
15c33ed to
9839ab7
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 15:03
a7b2f42 to
b604e88
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 15:03
9839ab7 to
1aa7df3
Compare
anurag4DSB
marked this pull request as ready for review
November 12, 2026 15:19
Add unit tests for the List handler on the in-memory backend, with records that Create stores. They check: - an empty account - name order, with each entry as Get answers it - an IAM user - another account, never listed - three names in two pages, through NextMarker then marker - the 100 default - each bad max-items (0, above the listing limit, abc, 2.5, empty, +5, repeated) and a repeated marker, with no listing - NextMarker escaped - store and record errors - no name, marker or record value in the logs Add functional tests through Create and Get. They check: - the same paging, under a prefix of their own - entries equal to Get's - an empty page after the last name - a second account's names, never shown - bad max-items 400 - anonymous 403 - an IAM user allowed on the account wildcard lists, while one allowed on a single destination gets 403 Each IAM test makes its own IAM users and destination, and removes the users when it ends.
notificationDestinationList: - reads max-items and an optional marker. When max-items is absent, the page size is 100. Else max-items must be digits only, from 1 to the listing limit of constants.js, listingHardLimit (1000). - lists the records of the requester's account from the record store - answers ListNotificationDestinationsResult: IsTruncated, NextMarker only when truncated, then one NotificationDestination per record. Each NotificationDestination is the element that Get answers. - answers InvalidArgument to a bad max-items or a repeated marker, before any listing - answers InternalError to a record that cannot be rendered The logs hold the account and the counts only. The handler reports its call to the Prometheus metrics, as the bucket APIs do.
anurag4DSB
force-pushed
the
improvement/CLDSRV-1065-destination-get
branch
from
November 12, 2026 15:57
b604e88 to
b78b066
Compare
anurag4DSB
force-pushed
the
improvement/CLDSRV-1066-destination-list
branch
from
November 12, 2026 15:58
1aa7df3 to
19b6121
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://claude.ai/artifact/QhKsCqtGNzaVice35nvip9#bcc30d01-27db.m1yth80jczv.20396
Intent: why does this change exist?
System impact: what's affected, including downstream?
Preserved behavior: what explicitly stays the same?
Intended change: what's different after this PR?
max-itemsup to the listing limit andNextMarker.Verification: how do we know this worked, or how would we know if it didn't?
mem.s3c-ft-testsandfile-ft-testscompare List entries with Get.https://claude.ai/code/session_01LSEjuApZSsJxDp6dw1FhVa