Repository navigation
CLDSRV-1060: Check the governance bypass permission on DeleteObject (hotfix/9.2.24) - #6365
Closed
leif-scality wants to merge 4 commits into
Closed
leif-scality wants to merge 4 commits into
leif-scality wants to merge 4 commits into
Conversation
The bypass action was added to the authorization only when sourceVersionId was set, which is the version of a copy source and is never set on a delete. So a delete of a specific version with x-amz-bypass-governance-retention removed a GOVERNANCE-locked version with only s3:DeleteObjectVersion, and a Deny on s3:BypassGovernanceRetention was ignored. Authorize s3:BypassGovernanceRetention on every delete of a specific version that sends the header. Call prepareRequestContexts in the unit tests as the API does for a delete, without a copy source, and add functional tests with IAM users against Vault. (cherry picked from commit 8cfe61b)
9.2.36 has neither the AWS SDK v3 nor the IAM test helper, so create the IAM users with the v2 IAM client, as bucketPolicyBypassPort.js does. (cherry picked from commit 63de57a)
The latest is 26 with breaks with tests needing python 3.9 (cherry picked from commit 8d58737)
Contributor
Hello leif-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I expected to find at least:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## hotfix/9.2.24 #6365 +/- ##
=================================================
+ Coverage 84.86% 84.89% +0.03%
=================================================
Files 206 206
Lines 13192 13192
=================================================
+ Hits 11195 11200 +5
+ Misses 1997 1992 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Not needed: 9.5.1 and 9.5.2 aren't among the versions requested on S3C-11612. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #6354 and #6360. The conflicts were formatting only. 9.2.24 has no AWS SDK v3, so the functional test uses the v2 SDK version from #6360. The CI runner pin (CLDSRV-1020) is cherry-picked too, as on #6360.