Repository navigation
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
a1588c2 to
41deec9
Compare
SylvainSenechal
left a comment
There was a problem hiding this comment.
Approved but I'm also thinking : As long as we don't bump drctl => we don't have any zenko ci issue 🤔
We are likely to add some more similar changes, so not sure we should open a pr like this every time we we change the param or similar 🤔
41deec9 to
c9aca87
Compare
Hm I see your point but we should ideally "fix" (and re-test e2e our ZKOP/DRCTL changes) as we develop them. Otherwise we'll do a big PR in 1 month and have to change/fix several items at once and maybe find some e2e failures on older changes |
francoisferrand
left a comment
There was a problem hiding this comment.
- Must not be merged in 2.16
- Will be needed once we bump zkop 1.10 (and matching drctl). But we are not there yet, and we may still want to merge updates to 2.17 BEFORE zkop 1.10 is "ready enough". Merging too soon with remove the flexibility to change/break zkop ↔ drctl interface: would need to synchronize releases/bumps of ZKOP and DRCTL, and prevent seamlessly integrating other devs (clickhouse, for exemple) into 2.17
|
/wait |
The bootstrap dump and load are only run by the operator's jobs, and no test calls them. Issue: ZENKO-5394
DrCtl renamed its --locations flag to --filter-locations, on install and on the bootstrap dump, as the locations now go into the filter of the DrCtl config of the D/R custom resources. Issue: ZENKO-5394
c9aca87 to
55e9a7e
Compare
|
Ack, waiting on 2.17 |
scality/zenko-operator#669 and scality/zenko-drctl#68 / scality/zenko-drctl#71 move the D/R bootstrap settings into an opaque DrCtl config on the D/R custom resources. As part of it, DrCtl renames its
--locationsflag to--filter-locations(oninstallandbootstrap dump), so the PRA test passesfilterLocationstodrctl install.The operator now writes the DrCtl job configs with nested keys, which only the new DrCtl reads: both have to be bumped together.
Issue: ZENKO-5394