Repository navigation
Track deployments of semver dev image tags at their commit - #2569
Conversation
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
600f217 to
1b88c10
Compare
1b88c10 to
deb4c42
Compare
|
Ah on the other pr on the dashboard, i saw this Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ It's from actions/github-script@v7, there is a v9 available that uses node 24. v7 is used in 6 places btw While we are at it, same issue with actions/setup-python@v5, v7 available |
|
/approve |
Images built with provenance attestations are tagged as an OCI image index, which the registry would not return as we only accepted image manifests. Accept index types, and when the index itself carries no revision, read it from the image manifest it points to. Issue: ZENKO-5389
Create used the image tag as deployment ref and fell back to the image revision when GitHub rejected it, while cleanup always listed deployments at the tag: those created at the image revision were never inactivated. Both now resolve the ref within the component repo the same way: the tag when it is a git ref of the repo, else the image revision. Looking up commits needs contents:read on the deployments token. Issue: ZENKO-5389
Branch images are now tagged as a dev pre-release of the next version, like 9.6.3-dev.2.sha-13bbb8b, which is no git ref of the repo. Take the commit from the sha- suffix of the tag, expanded to the full sha, so deployments do not depend on registry access and image annotations. Issue: ZENKO-5389
deb4c42 to
3c22f07
Compare
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue ZENKO-5389. Goodbye francoisferrand. The following options are set: approve |
Backbeat branch images are now tagged as a dev pre-release of the next version, like
9.6.3-dev.2.sha-13bbb8b(scality/backbeat#2910). Such a tag is no git ref of the repo, so the component deployment could not be created, and the image manifest fallback failed as well since the tag points to an OCI image index. Cleanup also listed deployments at the image tag, so deployments created at the resolved commit were never inactivated.sha-<hex>suffix of the tag, so dev tags do not depend on registry access.Looking up commits needs
contents:readon the deployments token: the GitHub App must have that permission.Issue: ZENKO-5389