Skip to content

refactor(cli): extract issue creation and assignment workflows - #268

Merged
ruby-automation merged 1 commit into
mainfrom
EXT-50-extract-issue-creation-and-assignment
Sep 12, 2026
Merged

refactor(cli): extract issue creation and assignment workflows#268
ruby-automation merged 1 commit into
mainfrom
EXT-50-extract-issue-creation-and-assignment

Conversation

@ruby-automation

Copy link
Copy Markdown
Contributor

Summary

  • Extracts make_da_issue!/1 and all private helpers from IssueHelpers into new CLI.Issue.Creation
  • Extracts gimme_da_issue!/2 and all private helpers from IssueHelpers into new CLI.Issue.Assignment
  • Updates all call sites in Commands and Profiles to the new modules (no shims, no logic duplication)
  • Splits tests into focused creation_test.exs and assignment_test.exs; removes the moved blocks from IssueHelpersTest and ProfileDefaultsTest

Closes EXT-50. Depends on EXT-48 (CLI.Issue.Identifiers and CLI.Issue.WorkflowStates), already merged as fe2199b.

Test plan

  • mix precommit clean: format ✓, credo strict (736 mods/funs, no issues) ✓, 493 tests pass ✓
  • CLI.Issue.CreationTest — 1 test covering make_da_issue!/1 with team/label/project resolution
  • CLI.Issue.AssignmentTest — 6 tests covering all gimme_da_issue!/2 branches (already-assigned, self-assign, status resolution, case-insensitive match, unknown status error, stateId mutation when already assigned)
  • ProfileDefaultsTest updated to call Creation.make_da_issue! directly — profile fallback behaviour unchanged

🤖 Generated with Claude Code

Moves `make_da_issue!/1` into `CLI.Issue.Creation` and
`gimme_da_issue!/2` into `CLI.Issue.Assignment`, leaving
`IssueHelpers` with only the remaining shared helpers. Updates all
call sites in `Commands`, splits tests into focused files, and drops
the moved tests from `IssueHelpersTest` and `ProfileDefaultsTest`.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ruby-automation
ruby-automation force-pushed the EXT-50-extract-issue-creation-and-assignment branch from d679039 to aa9dcf1 Compare September 12, 2026 00:01
@ruby-automation
ruby-automation merged commit c22e879 into main Sep 12, 2026
3 checks passed
@ruby-automation
ruby-automation deleted the EXT-50-extract-issue-creation-and-assignment branch September 12, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant