chore(harness): adds skill for linear issue creation via mix lc - #264
Merged
bougyman merged 6 commits intoSep 11, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Linear skill has unresolved label and self-assignment behavior issues, and the quality-gate change needs documentation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a Linear issue-management skill via mix lc and separates local precommit coverage from complete CI coverage.
Changes:
- Adds Linear issue creation and workflow guidance.
- Excludes
ci_onlytests frommix precommit. - Runs complete root and application suites in
mix ci. - Updates related tests and documentation.
File summaries
| File | Summary | Review findings |
|---|---|---|
test/mix/tasks/precommit_test.exs |
Verifies local test selection. | — |
test/mix/tasks/ci_test.exs |
Verifies complete CI test runs. | — |
test/git_hooks_test.exs |
Marks hook tests as CI-only. | — |
lib/mix/tasks/precommit.ex |
Excludes CI-only tests locally. | Nit (1 vote): document the quality-gate behavior change. |
lib/mix/tasks/ci.ex |
Runs complete root and application suites. | — |
documents/quality-gates-decision.adoc |
Documents updated gate behavior. | — |
.ai/skills/linear-cli/SKILL.md |
Adds Linear issue workflow guidance. | Moderate (3 votes): requested labels are not passed or applied. Moderate (1 vote): --yes triggers self-assignment even when no assignee was requested. |
Review details
Suppressed comments (3)
.ai/skills/linear-cli/SKILL.md:39
--yesis not only a prompt-suppression flag here:issue createautomatically calls the self-assignment flow. This prescribed command therefore assigns every new issue to the current user even when no assignee was requested, while the later step has no way to preserve an unassigned issue. Use or add a CLI path that disables self-assignment, or document this behavior as a required part of the workflow.
mix lc issue create --yes \
--team TEAM \
--project PROJECT \
--title TITLE \
--body-file BODY_FILE
.ai/skills/linear-cli/SKILL.md:46
- This post-create step only covers the case where both an assignee and a status were requested. If only a status is requested, there is no instruction to apply it; using
issue assignwithout--assigneewould prompt interactively. Document the separateissue status ISSUE_ID --status STATUSpath and the assignee-only path, while retaining the combined command for requests that include both.
4. Capture the returned identifier. When the user specified an assignee and
status, apply both explicitly:
```sh
mix lc issue assign --assignee ASSIGNEE --status STATUS ISSUE_ID
lib/mix/tasks/precommit.ex:46
- The PR description only mentions adding the Linear issue skill, but this change also alters the quality gates: local root tests now exclude
ci_only, andmix ciadds a full root test run. Please document this behavioral change or split it so the gate changes receive explicit review.
shell.("mix", ["test", "--exclude", "ci_only"], [])
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bougyman
deleted the
bougyman/ext-55-featskills-add-shared-linear-cli-issue-management-skill
branch
September 11, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
explicit assignment/status handling, labels, and dependency verification.
issue create --no-takeso automated issue creation can remainunassigned unless the requester explicitly chooses an assignee.
mix precommitgate from the completemix cigate:local root and app tests exclude
ci_only, while CI runs both suites withouttest selection.
Validation
cd app && mix test test/linear_cli/cli/issue_commands_test.exs