Skip to content

chore(harness): adds skill for linear issue creation via mix lc - #264

Merged
bougyman merged 6 commits into
mainfrom
bougyman/ext-55-featskills-add-shared-linear-cli-issue-management-skill
Sep 11, 2026
Merged

chore(harness): adds skill for linear issue creation via mix lc#264
bougyman merged 6 commits into
mainfrom
bougyman/ext-55-featskills-add-shared-linear-cli-issue-management-skill

Conversation

@bougyman

@bougyman bougyman commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a repository-shared Linear CLI skill with body-file-based issue creation,
    explicit assignment/status handling, labels, and dependency verification.
  • Add issue create --no-take so automated issue creation can remain
    unassigned unless the requester explicitly chooses an assignee.
  • Split the fast local mix precommit gate from the complete mix ci gate:
    local root and app tests exclude ci_only, while CI runs both suites without
    test selection.

Validation

  • cd app && mix test test/linear_cli/cli/issue_commands_test.exs

Copilot AI lite review requested due to automatic review settings September 11, 2026 21:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Linear skill has unresolved label and self-assignment behavior issues, and the quality-gate change needs documentation.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a Linear issue-management skill via mix lc and separates local precommit coverage from complete CI coverage.

Changes:

  • Adds Linear issue creation and workflow guidance.
  • Excludes ci_only tests from mix precommit.
  • Runs complete root and application suites in mix ci.
  • Updates related tests and documentation.
File summaries
File Summary Review findings
test/mix/tasks/precommit_test.exs Verifies local test selection.
test/mix/tasks/ci_test.exs Verifies complete CI test runs.
test/git_hooks_test.exs Marks hook tests as CI-only.
lib/mix/tasks/precommit.ex Excludes CI-only tests locally. Nit (1 vote): document the quality-gate behavior change.
lib/mix/tasks/ci.ex Runs complete root and application suites.
documents/quality-gates-decision.adoc Documents updated gate behavior.
.ai/skills/linear-cli/SKILL.md Adds Linear issue workflow guidance. Moderate (3 votes): requested labels are not passed or applied. Moderate (1 vote): --yes triggers self-assignment even when no assignee was requested.
Review details

Suppressed comments (3)

.ai/skills/linear-cli/SKILL.md:39

  • --yes is not only a prompt-suppression flag here: issue create automatically calls the self-assignment flow. This prescribed command therefore assigns every new issue to the current user even when no assignee was requested, while the later step has no way to preserve an unassigned issue. Use or add a CLI path that disables self-assignment, or document this behavior as a required part of the workflow.
   mix lc issue create --yes \
     --team TEAM \
     --project PROJECT \
     --title TITLE \
     --body-file BODY_FILE

.ai/skills/linear-cli/SKILL.md:46

  • This post-create step only covers the case where both an assignee and a status were requested. If only a status is requested, there is no instruction to apply it; using issue assign without --assignee would prompt interactively. Document the separate issue status ISSUE_ID --status STATUS path and the assignee-only path, while retaining the combined command for requests that include both.
4. Capture the returned identifier. When the user specified an assignee and
   status, apply both explicitly:

   ```sh
   mix lc issue assign --assignee ASSIGNEE --status STATUS ISSUE_ID

lib/mix/tasks/precommit.ex:46

  • The PR description only mentions adding the Linear issue skill, but this change also alters the quality gates: local root tests now exclude ci_only, and mix ci adds a full root test run. Please document this behavioral change or split it so the gate changes receive explicit review.
    shell.("mix", ["test", "--exclude", "ci_only"], [])
  • Files reviewed: 9/9 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .ai/skills/linear-cli/SKILL.md Outdated
@bougyman
bougyman merged commit 4200469 into main Sep 11, 2026
3 checks passed
@bougyman
bougyman deleted the bougyman/ext-55-featskills-add-shared-linear-cli-issue-management-skill branch September 11, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants