docs: plan injectable request reply callbacks - #56
Merged
Merged
Conversation
bougyman
force-pushed
the
enable-injectable-request-reply-callbacks
branch
from
September 14, 2026 18:36
94902a5 to
66b3412
Compare
bougyman
force-pushed
the
enable-injectable-request-reply-callbacks
branch
from
September 14, 2026 18:39
66b3412 to
93e9b4e
Compare
KBerryPP
approved these changes
Sep 14, 2026
gabeodess
reviewed
Sep 14, 2026
Comment on lines
+78
to
+81
| on_failure: ->(wrapper, result) do | ||
| @failure_log_policy.call(result.failure) | ||
| wrapper.respond_with_error(result.failure) | ||
| end, |
There was a problem hiding this comment.
Would the update use @failure_log_policy as the default so we could inject that without overwriting callbacks?
Allow services to customize or suppress failure logging
NOTE: We're preserving the default error-level log and
existing error response behavior, for now. We can
make that injectable later.
Inline the default failure log policy and shorten the policy-injection test to make YARD and RuboCop happy without changing callback behavior.
drhinehart
approved these changes
Sep 15, 2026
bfl3tch
approved these changes
Sep 15, 2026
bougyman
pushed a commit
that referenced
this pull request
Sep 16, 2026
This also adds the injectable error logging from #56, which should have been another feat: but I mistakenly pushed it as a docs:, so it didn't cut a release or hit the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision requested
Approve the proposed request/reply callback injection design before implementation begins.
Proposed design
NatsRequestReplyCallbacksbehavior as the default resolver result.#callbacks; it must not inherit from or mix in Leopard code.Non-goals
Acceptance criteria for follow-up implementation
logger:and returns a callback object with#callbacks.respond_with_error(failure).