Skip to content

Fix specs for Process.exec to prevent execve call and silent process termination #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrykonchin merged 1 commit into from
Aug 28, 2026
+9 −6
Merged

Fix specs for Process.exec to prevent execve call and silent process termination #1392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions core/process/exec_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,20 +240,23 @@
end

describe "options validation" do
# Use a non-existent command to prevent unexpected execve() calls and
# provide clearer failures if options aren't validated.

it "raises an ArgumentError if :unsetenv_others option is not a boolean or nil" do
-> { Process.exec("true", unsetenv_others: 1) }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("true", unsetenv_others: "true") }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("should_raise_before_and_not_run", unsetenv_others: 1) }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("should_raise_before_and_not_run", unsetenv_others: "true") }.should.raise(ArgumentError, /expected true or false/)
end

it "raises an ArgumentError if :close_others option is not a boolean or nil" do
-> { Process.exec("true", close_others: 1) }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("true", close_others: "true") }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("should_raise_before_and_not_run", close_others: 1) }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("should_raise_before_and_not_run", close_others: "true") }.should.raise(ArgumentError, /expected true or false/)
end

platform_is :windows do
it "raises an ArgumentError if :new_pgroup option is not a boolean or nil" do
-> { Process.exec("true", new_pgroup: 1) }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("true", new_pgroup: "true") }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("should_raise_before_and_not_run", new_pgroup: 1) }.should.raise(ArgumentError, /expected true or false/)
-> { Process.exec("should_raise_before_and_not_run", new_pgroup: "true") }.should.raise(ArgumentError, /expected true or false/)
end
end
end
Expand Down