Add memoized page lookup index to RDoc::Store - #1794
Closed
skatkov wants to merge 1 commit into
Closed
Conversation
skatkov
requested a deployment
to
fork-preview-protection
August 29, 2026 09:28 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
Author
|
So, after testing more... this speed up is barely <2% insignificant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page(name)currently resolves page lookups by scanning everyTopLevelin@files_hasheach time it’s called (each_value.each_with_object(...)). In large documentation sets (or in server/live reload flows where lookups happen repeatedly), this results in repeated linear scans.This PR introduces
@page_indexas a memoized secondary index keyed by bothpage_nameandbase_nameto avoid that repeated work and make page lookup O(1) on steady-state access.Benchmarks
Based on my findings, speed-up is noticeable in gems with many pages. This improvement doesn't affect smaller gems.
-> TODO: add exact numbers