Fix parser silently accepting a lone trailing surrogate in string values - #1070
Open
elang2 wants to merge 1 commit into
Open
Fix parser silently accepting a lone trailing surrogate in string values#1070elang2 wants to merge 1 commit into
elang2 wants to merge 1 commit into
Conversation
The C parser guards leading-first surrogate pairs but silently accepts a lone trailing surrogate, encoding U+DC00..U+DFFF as three UTF-8 bytes into the output buffer. The returned Ruby String is tagged UTF-8 but fails valid_encoding? and raises misleading errors from downstream String operations (upcase, split, regex, encode, JSON.generate). Add a symmetric branch alongside the leading-surrogate check to raise JSON::ParserError at the parse boundary. Extend test_invalid_surogates with the new cases and move the three JSONTestSuite fixtures that this fix newly rejects from INVALID_ENCODING_TESTS into UNDEFINED_FAILING, closing the CRuby/JRuby parser parity gap documented in the file.
Author
|
Thanks @byroot for the triage on #1069. You closed it as a duplicate of the broader #138 (invalid-UTF-8 acceptance, open since 2012). Would a narrow scoped fix like this PR (lone-trailing surrogate in \uXXXX escape decoding, mirroring the leading-first fix that landed in 5855f4f) be welcome as a partial step toward #138? |
Member
|
Yeah, the parser as gotten more strict over time, since the 3.0 is around the corner it may be an occasion to make it stricter again. I'll see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1069.
Adds the symmetric
else if ((ch & 0xFC00) == 0xDC00)branch injson_string_unescapeso a lone trailing surrogate escape raisesJSON::ParserErrorat the parse boundary instead of writingED B0 80into the output buffer and returning a String that failsvalid_encoding?.The Java parser at
java/src/json/ext/StringDecoder.java:104-105already rejects lone trailing surrogates; this closes the CRuby/JRuby parity gap the minefield test file documents at lines 41-43.