Preserve repeated linker options and their arguments - #54
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop globally deduplicating individual linker tokens. Preserve repeated -framework/-Xlinker/group markers while retaining the existing joined -L/-l deduplication policy.
Reproduction and verification
A .pc file containing
Libs: -framework Cocoa -framework Carboncurrently produces-framework Cocoa Carbon, so Carbon is no longer an argument to -framework. Likewise-Xlinker --as-needed -Xlinker --no-as-neededloses its second -Xlinker. Generic token uniqueness also removes repeated group delimiters. The candidate keeps these sequences intact.Five public .pc fixtures pass; four fail on baseline. Existing splitter and native GLib/MSVC-style checks still pass.
Existing suite on Ruby 4.0.6 through rbenv: 27 tests, 31 assertions, zero failures/errors, two upstream macOS omissions, baseline and this isolated patch. Combined installed-release consumer also passes the suite, 1,098 focused/model checks, four process cases, five linker-option cases and four path cases.
rbenv exec ruby test/run.rbruns the existing suite.Compatibility and limitations
Output may now contain repeated non-library flags, deliberately preserving their positional semantics. This is not a complete linker-language parser: quoted paths, repeated -l requirements across link groups and dependency ordering remain separate work. Native Windows/MSVC was not run.
No tests were added or modified under the consuming repository's no-new-tests policy. Verification uses existing tests and external scratch reproductions. No production changes; older Ruby/Linux/Windows matrices await upstream CI. No unrelated version/dependency changes.