Let explicit PKG_CONFIG_LIBDIR replace default search paths - #53
Open
OskarEichler wants to merge 2 commits into
Open
Let explicit PKG_CONFIG_LIBDIR replace default search paths#53OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use PKG_CONFIG_LIBDIR as the replacement default search path, including when it is explicitly empty; retain higher-priority configured/PKG_CONFIG_PATH entries.
Reproduction and verification
Setting
PKG_CONFIG_LIBDIRto a target directory currently still appends host/native and platform defaults. An empty value also leaves host directories enabled. Four isolated path fixtures fail on baseline and pass with the candidate; twelve native pkgconf lookups confirm the replacement/empty semantics. No host package installation or environment persistence is required.Four configured/environment/empty/multiple-directory cases and twelve native lookup checks pass. Reference: https://github.com/pkgconf/pkgconf/blob/master/man/pkgconf.1 (PKG_CONFIG_LIBDIR environment section).
Existing suite on Ruby 4.0.6 through rbenv: 27 tests, 31 assertions, zero failures/errors, two upstream macOS omissions, baseline and this isolated patch. Combined installed-release consumer also passes the suite, 1,098 focused/model checks, four process cases, five linker-option cases and four path cases.
rbenv exec ruby test/run.rbruns the existing suite.Compatibility and limitations
Intentional compatibility correction: callers that used PKG_CONFIG_LIBDIR as an additive path must use PKG_CONFIG_PATH instead. When LIBDIR is unset, existing platform discovery is unchanged. No complete cross-compilation/toolchain claim.
No tests were added or modified under the consuming repository's no-new-tests policy. Verification uses existing tests and external scratch reproductions. No production changes; older Ruby/Linux/Windows matrices await upstream CI. No unrelated version/dependency changes.