build: 🧑💻 Add make targets for abctl and authbridge-proxy - #974
Conversation
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe repository adds root-level Make targets for ChangesBinary build workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Developer
participant Makefile
participant ProfileTags
participant GoBuild
Developer->>Makefile: Run make abctl or make authbridge-proxy
Makefile->>ProfileTags: Resolve the selected plugin profile
ProfileTags-->>Makefile: Return plugin build tags
Makefile->>GoBuild: Build the selected command into bin
GoBuild-->>Developer: Produce the binary or return an error
Merge Risk: ⚪ Minimal · up to The new build targets are mergeable with no identified material risk remaining. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
huang195
left a comment
There was a problem hiding this comment.
Small and well-shaped. Routing the tag list through scripts/profile-tags means the plugin set can't drift from the profile definitions, and full as the default answers the exact question #914 raised — it is the 13-plugin set the authbridge image ships, so "which plugins do we intend by default" now has a correct answer a developer can reproduce.
A few things I checked rather than assumed:
- The failure claim in the comment holds. A simple assignment's exit status is the command substitution's, so
TAGS=$(…) && cd … && go buildreally does short-circuit and fail the target on a mistyped profile. Worth having verified, because the alternative would have been an empty tag list quietly building a plugin-less binary. -o $(BIN_DIR)/…survives thecd, sinceBIN_DIR := $(CURDIR)/binis absolute.$(or $(PROFILE),full)covers both unset and explicitly-emptyPROFILE=.- No ordering hazard: #970 merged earlier today, so
authbridge/scripts/profile-tagsis onmain. - The README anchor resolves to the existing
## Build-tag plugin selectionheading, and the scope matches what #914 asked for, soClosesis accurate.
Two non-blocking notes inline.
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Summary
Adds
make abctlandmake authbridge-proxyat the repo root so a developer can build the binaries without knowing which plugin tags to pass. Both land in./bin/.authbridge-proxytakes aPROFILE=knob (fulldefault, orlite/local) and resolves the tag list viaauthbridge/scripts/profile-tags.Assisted-By: Claude (Anthropic AI) noreply@anthropic.com
Related issue(s)
Closes #914
Summary by CodeRabbit
New Features
abctlandauthbridge-proxybinaries.authbridge-proxybuilds with the default full plugin profile, with options for lite and local profiles.bindirectory.Documentation
authbridge-proxy.