Skip to content

build: 🧑‍💻 Add make targets for abctl and authbridge-proxy - #974

Merged
evaline-ju merged 2 commits into
rossoctl:mainfrom
evaline-ju:make-targets
Sep 11, 2026
Merged

build: 🧑‍💻 Add make targets for abctl and authbridge-proxy#974
evaline-ju merged 2 commits into
rossoctl:mainfrom
evaline-ju:make-targets

Conversation

@evaline-ju

@evaline-ju evaline-ju commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds make abctl and make authbridge-proxy at the repo root so a developer can build the binaries without knowing which plugin tags to pass. Both land in ./bin/. authbridge-proxy takes a PROFILE= knob (full default, or lite / local) and resolves the tag list via authbridge/scripts/profile-tags.

Assisted-By: Claude (Anthropic AI) noreply@anthropic.com

Related issue(s)

Closes #914

Summary by CodeRabbit

  • New Features

    • Added convenient build targets for the abctl and authbridge-proxy binaries.
    • authbridge-proxy builds with the default full plugin profile, with options for lite and local profiles.
    • Builds now place generated binaries in a dedicated bin directory.
  • Documentation

    • Updated source-build instructions to use the new Make targets from the repository root.
    • Added guidance for selecting plugin profiles when building authbridge-proxy.

Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: be5cac8e-9e30-4243-91c0-ea362d51d91a

📥 Commits

Reviewing files that changed from the base of the PR and between 071a0b3 and 47db006.

📒 Files selected for processing (1)
  • Makefile

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f67a55ef-073c-4c18-adfc-40bded4d9e57

📥 Commits

Reviewing files that changed from the base of the PR and between 6b0022e and 071a0b3.

📒 Files selected for processing (3)
  • .gitignore
  • Makefile
  • authbridge/README.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The repository adds root-level Make targets for abctl and authbridge-proxy. The proxy target selects plugin tags from a profile, writes binaries to bin/, ignores that directory, and updates the README instructions.

Changes

Binary build workflow

Layer / File(s) Summary
Build targets and output handling
Makefile, .gitignore
The Makefile adds abctl and authbridge-proxy targets. The proxy target defaults to the full profile and supports lite and local. Build outputs use bin/, which .gitignore now excludes.
Build instructions
authbridge/README.md
The README now directs developers to use the root-level Make targets and documents the proxy profiles.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: huang195

Sequence Diagram(s)

sequenceDiagram
  participant Developer
  participant Makefile
  participant ProfileTags
  participant GoBuild
  Developer->>Makefile: Run make abctl or make authbridge-proxy
  Makefile->>ProfileTags: Resolve the selected plugin profile
  ProfileTags-->>Makefile: Return plugin build tags
  Makefile->>GoBuild: Build the selected command into bin
  GoBuild-->>Developer: Produce the binary or return an error
Loading

Merge Risk: ⚪ Minimal · up to 071a0

The new build targets are mergeable with no identified material risk remaining.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding Make targets for building abctl and authbridge-proxy.
Linked Issues check ✅ Passed The PR meets issue #914. The root Makefile adds abctl and authbridge-proxy targets that write binaries to ./bin/. The proxy target uses the full profile by default and accepts lite and `loca…
Out of Scope Changes check ✅ Passed The changes stay within issue #914. The Makefile changes implement the requested build targets. The README changes document the expected commands and plugin configuration. The .gitignore change supp…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@huang195 huang195 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small and well-shaped. Routing the tag list through scripts/profile-tags means the plugin set can't drift from the profile definitions, and full as the default answers the exact question #914 raised — it is the 13-plugin set the authbridge image ships, so "which plugins do we intend by default" now has a correct answer a developer can reproduce.

A few things I checked rather than assumed:

  • The failure claim in the comment holds. A simple assignment's exit status is the command substitution's, so TAGS=$(…) && cd … && go build really does short-circuit and fail the target on a mistyped profile. Worth having verified, because the alternative would have been an empty tag list quietly building a plugin-less binary.
  • -o $(BIN_DIR)/… survives the cd, since BIN_DIR := $(CURDIR)/bin is absolute.
  • $(or $(PROFILE),full) covers both unset and explicitly-empty PROFILE=.
  • No ordering hazard: #970 merged earlier today, so authbridge/scripts/profile-tags is on main.
  • The README anchor resolves to the existing ## Build-tag plugin selection heading, and the scope matches what #914 asked for, so Closes is accurate.

Two non-blocking notes inline.

Comment thread Makefile Outdated
Comment thread Makefile
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
@evaline-ju
evaline-ju merged commit e1b864b into rossoctl:main Sep 11, 2026
25 checks passed
@github-project-automation github-project-automation Bot moved this from New/ToDo to Done in Rossoctl Issue Prioritization Sep 11, 2026
@evaline-ju
evaline-ju deleted the make-targets branch September 11, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feature: make targets for building abctl and authbridge-proxy

3 participants