Separate on-chain state from reconstructed data - #1200
Open
jshufro wants to merge 1 commit into
Open
Conversation
0xfornax
requested changes
Aug 31, 2026
0xfornax
left a comment
0xfornax
left a comment
Member
There was a problem hiding this comment.
GetBulkMegapoolDetails is being called with no addresses and returns an empty map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous, NetworkState had a mix of fields: fields that directly map to storage on either the evm or beacon chain mixed with fields derived from the former.
This PR separates the derived fields into a separate, encapsulating type. This is a small reduction in tech debt, as maintainers no longer need to worry about whether or not they have called
CalculateAverageFeeAndDistributorSharesbefore accessing the state.Further deconstruction of the treegen state machines will make it easier to make them more modular in the future. We update them to taking the state index from NewGenerator to GenerateTree, which shifts the dependency on data away from init-time and towards runtime. Ultimately we should fully remove state from the treegen structs and pass data to its subroutines on a case by case basis.