Skip to content

fix : forward client configuration and actor access options - #5956

Open
anbv29 wants to merge 4 commits into
rivet-dev:mainfrom
anbv29:fix/effect-client-options
Open

anbv29 wants to merge 4 commits into
rivet-dev:mainfrom
anbv29:fix/effect-client-options

Conversation

@anbv29

@anbv29 anbv29 commented Oct 31, 2026

Copy link
Copy Markdown
  • Accept the full raw client configuration, including poolName.
  • Forward connection and creation options through Actor.Accessor.getOrCreate.
  • Export GetOrCreateOptions from rivetkit/client.
  • Add regression coverage for forwarding, existing calls, option isolation, and typed errors.
  • Syntax and whitespace checks passed. Tests and full typechecking remain unverified because dependency downloads failed.

Closes #5922

@RivetAgent

Copy link
Copy Markdown
Contributor

The changes look good: client and per-actor options are forwarded consistently, with regression tests covering configuration, handle isolation, and typed errors.

No issues found. Checked for bugs and CLAUDE.md compliance; no CLAUDE.md files were present.

Review limited to the local commit range: GitHub authentication was unavailable, and tests were not run.

Copy prompt to fix all
Fix all actionable findings in the latest Ironworks code review on PR rivet-dev/rivet#5956. Inspect every referenced location, address each finding without changing unrelated behavior, run the relevant tests, and summarize what changed.

@anbv29

anbv29 commented Nov 12, 2026

Copy link
Copy Markdown
Author

hey @gabrielsch, PR #5956 is up for this issue. it widens the effect client options and forwards params, createInRegion and poolName through getOrCreate. review came back clean and the client tests pass. happy to tweak anything

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@rivetkit/effect: Client options for params, poolName and region

2 participants