Upgrade to Go 1.26 + golangci-lint 2.13.1 - #54
Merged
Conversation
The rivershared v0.45.0 update raises its module minimum to Go 1.26, above the version used to build the pinned golangci-lint binary. Lint therefore exits before analyzing code. Declare Go 1.26 as the library minimum and use stable Go with golangci-lint 2.13.1, matching the current River pattern. Upgrade the supporting GitHub Actions to their current major versions so they run on a supported Node runtime instead of GitHub's Node 20 fallback.
bgentry
force-pushed
the
bg/modernize-ci-go-1.27
branch
from
September 1, 2026 01:12
8623ff0 to
1f857ae
Compare
bgentry
changed the title
The newer lint suite introduces replacement linters for existing policy choices and enables additional checks through `default: all`. Preserve the intent of the exhaustive-struct policy, switch away from deprecated linter aliases, and avoid noisy repeated-literal and whitespace churn. Apply the useful Go modernization fixes emitted by the updated linter. Adopt typed error and reflection helpers, standard-library iterators and pointer expressions, efficient string construction, promoted embedded fields, and context-aware test requests.
bgentry
force-pushed
the
bg/modernize-ci-go-1.27
branch
from
September 1, 2026 01:14
1f857ae to
3a53f5a
Compare
bgentry
enabled auto-merge (squash)
September 1, 2026 01:25
brandur
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
riversharedv0.45 update raises its Go requirement, exposing that CI's pinned golangci-lint 2.4 binary was built with an older Go release and exits before linting. Declare Go 1.26 as the library minimum while running lint with stable Go and golangci-lint 2.13.1, matching the current River pattern without forcing Go 1.27 ontoriverapiorriverui.Upgrade checkout, Go setup, and golangci-lint actions to versions that use a supported Node runtime, removing the Node 20 deprecation warning. Apply the lint configuration migrations and Go modernizations required by the newer suite, including explicit contexts for HTTP test requests.