Skip to content

feat(guide): add base document metadata [Codex] - #1348

Merged
jderochervlk merged 4 commits into
masterfrom
feat/guide-metadata
Sep 13, 2026
Merged

jderochervlk merged 4 commits into
masterfrom
feat/guide-metadata

Conversation

@jderochervlk

Copy link
Copy Markdown
Collaborator

The standalone guide currently has only a document title, so browser chrome and installed-app surfaces lack a description, theme color, and official ReScript icon references.

This adds the guide application name, a concise non-lesson description, and theme color to the root document. It reuses the repository's official favicon set as the guide's Vite public directory, keeping the deployed assets scoped to the favicon files without duplicating branding.

Canonical URLs, robots behavior, and a social-preview image remain intentionally undecided because they depend on the guide's public-domain and discovery decisions.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T19:43:20.645434Z d7e7a4b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 13, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide d7e7a4b Commit Preview URL

Branch Preview URL
Sep 13 2026, 07:37 PM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d39092c90c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/guide/vite.config.mjs
Comment thread apps/guide/app/root.res Outdated
Keep shared favicon assets while leaving install-manifest ownership to a future guide-specific implementation.
Keep the tracked ReScript output aligned with the repository formatting gate.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9109eebd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/guide/app/root.res
@github-actions

Copy link
Copy Markdown
Contributor

Guide Cloudflare deployment

⛅️ wrangler 4.114.0
────────────────────
🌀 Building list of assets...
✨ Read 16 files from the assets directory /home/runner/work/rescript-lang.org/rescript-lang.org/apps/guide/out
🌀 Starting asset upload...
🌀 Found 4 new or modified static assets to upload. Proceeding with upload...

  • /assets/manifest-dee78157.js
  • /assets/GuideHomeRoute-CSf4BlnB.js
  • /__spa-fallback.html
  • /index.html
    Uploaded 1 of 4 assets
    Uploaded 2 of 4 assets
    Uploaded 4 of 4 assets
    ✨ Success! Uploaded 4 files (11 already uploaded) (2.25 sec)

Total Upload: 0.31 KiB / gzip: 0.22 KiB
Worker Startup Time: 0 ms
Uploaded guide (4.20 sec)
Worker Version ID: 55dba982-ce6c-48c2-9de6-7432037c4040
Version Preview URL: https://55dba982-guide.rescript.workers.dev
Version Preview Alias URL: https://feat-guide-metadata-guide.rescript.workers.dev

To deploy this version to production traffic use the command wrangler versions deploy

Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy

Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare deployment

Deployement ID: cc4b1d8c-9b13-44d3-86d3-b1ce3ad4da39
Deployment Environment: preview

⛅️ wrangler 4.114.0
────────────────────
✨ Compiled Worker successfully
Uploading... (8768/8770)
Uploading... (8769/8770)
Uploading... (8770/8770)
✨ Success! Uploaded 2 files (8768 already uploaded) (1.64 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://cc4b1d8c.rescript-lang.pages.dev
✨ Deployment alias URL: https://feat-guide-metadata.rescript-lang.pages.dev

@jderochervlk
jderochervlk merged commit df7a208 into master Sep 13, 2026
9 checks passed
@jderochervlk
jderochervlk deleted the feat/guide-metadata branch September 13, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants