Skip to content

feat(guide): add desktop screen warning [Codex] - #1347

Merged
jderochervlk merged 2 commits into
masterfrom
a11y/guide-desktop-warning
Sep 13, 2026
Merged

jderochervlk merged 2 commits into
masterfrom
a11y/guide-desktop-warning

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

The interactive guide requires a desktop workspace, but the existing narrow-screen fallback did not clearly communicate that product constraint. Keyboard users also relied on default browser focus styling for its primary controls.

The narrow viewport now displays an explicit desktop-browser requirement and keeps the interactive shell hidden. The guide adds visible focus rings for the theme toggle, lesson navigation, and editor. Viewport tests cover both sides of the 1024px threshold.

image

Show an explicit desktop requirement below the guide's minimum viewport and make keyboard focus clear for primary controls.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T14:39:55.239071Z 7bb735a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 13, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 0e1954e Commit Preview URL

Branch Preview URL
Sep 13 2026, 05:33 PM

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bb735a52d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/guide/styles/main.css Outdated
Target CodeMirror's focused editor state so keyboard focus receives the intended visible indicator.
@github-actions

Copy link
Copy Markdown
Contributor

Guide Cloudflare deployment

⛅️ wrangler 4.114.0
────────────────────
🌀 Building list of assets...
✨ Read 10 files from the assets directory /home/runner/work/rescript-lang.org/rescript-lang.org/apps/guide/out
🌀 Starting asset upload...
🌀 Found 5 new or modified static assets to upload. Proceeding with upload...

  • /assets/root-BtDlz4sP.js
  • /assets/main-D3VQpRmh.css
  • /assets/manifest-f3d82c8d.js
  • /index.html
  • /__spa-fallback.html
    Uploaded 1 of 5 assets
    Uploaded 3 of 5 assets
    Uploaded 5 of 5 assets
    ✨ Success! Uploaded 5 files (4 already uploaded) (0.74 sec)

Total Upload: 0.31 KiB / gzip: 0.22 KiB
Worker Startup Time: 0 ms
Uploaded guide (2.01 sec)
Worker Version ID: e74c9fb0-661b-42c0-9f07-f5ba170edcee
Version Preview URL: https://e74c9fb0-guide.rescript.workers.dev
Version Preview Alias URL: https://a11y-guide-desktop-warning-guide.rescript.workers.dev

To deploy this version to production traffic use the command wrangler versions deploy

Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy

Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare deployment

Deployement ID: 216a9a1b-3083-4c12-a7ea-ee99d00809d1
Deployment Environment: preview

⛅️ wrangler 4.114.0
────────────────────
✨ Compiled Worker successfully
Uploading... (8768/8770)
Uploading... (8769/8770)
Uploading... (8770/8770)
✨ Success! Uploaded 2 files (8768 already uploaded) (1.05 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://216a9a1b.rescript-lang.pages.dev
✨ Deployment alias URL: https://a11y-guide-desktop-warning.rescript-lang.pages.dev

@jderochervlk
jderochervlk merged commit b265d03 into master Sep 13, 2026
9 checks passed
@jderochervlk
jderochervlk deleted the a11y/guide-desktop-warning branch September 13, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants