Skip to content

fix(guide): silence Vite env deprecation [Codex] - #1344

Closed
jderochervlk wants to merge 1 commit into
masterfrom
build/guide-vite-config
Closed

jderochervlk wants to merge 1 commit into
masterfrom
build/guide-vite-config

Conversation

@jderochervlk

Copy link
Copy Markdown
Collaborator

Vite 8.1 deprecates the envFile: false option used internally by React Router 7.15, causing repeated warnings during guide builds. The maintained React Router 7.x line does not include the upstream compatibility fix, while upgrading the guide to React Router 8 would require a separate migration.

The guide now uses a Yarn patch for its existing @react-router/dev@7.15.0 dependency. It replaces the four internal Vite child-compiler uses of envFile: false with the supported envDir: false setting. The patch is scoped only to the guide workspace and recorded in the lockfile for reproducible installs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T14:35:30.048810Z 8ca2382 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 8ca2382 Commit Preview URL

Branch Preview URL
Sep 13 2026, 02:32 PM

@github-actions

Copy link
Copy Markdown
Contributor

Guide Cloudflare deployment

⛅️ wrangler 4.114.0
────────────────────
🌀 Building list of assets...
✨ Read 10 files from the assets directory /home/runner/work/rescript-lang.org/rescript-lang.org/apps/guide/out
🌀 Starting asset upload...
No updated asset files to upload. Proceeding with deployment...
Total Upload: 0.31 KiB / gzip: 0.22 KiB
Worker Startup Time: 0 ms
Uploaded guide (1.27 sec)
Worker Version ID: 51ed3899-1a09-44b7-a2f7-2ddd24a3c2f0
Version Preview URL: https://51ed3899-guide.rescript.workers.dev
Version Preview Alias URL: https://build-guide-vite-config-guide.rescript.workers.dev

To deploy this version to production traffic use the command wrangler versions deploy

Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy

Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare deployment

Deployement ID: 9246d60e-4241-4966-aea0-f64f8dcab9fb
Deployment Environment: preview

⛅️ wrangler 4.114.0
────────────────────
✨ Compiled Worker successfully
Uploading... (8290/8770)
Uploading... (8450/8770)
Uploading... (8610/8770)
Uploading... (8770/8770)
✨ Success! Uploaded 480 files (8290 already uploaded) (2.97 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://9246d60e.rescript-lang.pages.dev
✨ Deployment alias URL: https://build-guide-vite-config.rescript-lang.pages.dev

@jderochervlk

Copy link
Copy Markdown
Collaborator Author

We can skip doing this and just update to Vite 8 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant