Skip to content

chore(guide): satisfy React type peer dependency [Codex] - #1343

Merged
jderochervlk merged 1 commit into
masterfrom
chore/guide-react-types
Sep 13, 2026
Merged

chore(guide): satisfy React type peer dependency [Codex]#1343
jderochervlk merged 1 commit into
masterfrom
chore/guide-react-types

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

The guide workspace emitted a peer-dependency warning because packages in its dependency tree request @types/react, while the workspace did not provide it.

This adds the already-locked React type package as a development dependency, matching the docs workspace and satisfying the guide's peer requirements without changing the production dependency graph.

Add the existing React type package as a guide development dependency to satisfy workspace peer requirements.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T14:29:53.322891Z 640c735 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Guide Cloudflare deployment

⛅️ wrangler 4.114.0
────────────────────
🌀 Building list of assets...
✨ Read 10 files from the assets directory /home/runner/work/rescript-lang.org/rescript-lang.org/apps/guide/out
🌀 Starting asset upload...
No updated asset files to upload. Proceeding with deployment...
Total Upload: 0.31 KiB / gzip: 0.22 KiB
Worker Startup Time: 0 ms
Uploaded guide (1.35 sec)
Worker Version ID: 7e61190d-ea48-4271-91cb-d8e081d387d7
Version Preview URL: https://7e61190d-guide.rescript.workers.dev
Version Preview Alias URL: https://chore-guide-react-types-guide.rescript.workers.dev

To deploy this version to production traffic use the command wrangler versions deploy

Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy

Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
guide 640c735 Commit Preview URL

Branch Preview URL
Sep 13 2026, 02:29 PM

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare deployment

Deployement ID: 2b90e19c-d141-4ab8-a251-822046747137
Deployment Environment: preview

⛅️ wrangler 4.114.0
────────────────────
✨ Compiled Worker successfully
Uploading... (8289/8770)
Uploading... (8450/8770)
Uploading... (8610/8770)
Uploading... (8770/8770)
✨ Success! Uploaded 481 files (8289 already uploaded) (3.32 sec)

✨ Uploading _redirects
✨ Uploading Functions bundle
🌎 Deploying...
✨ Deployment complete! Take a peek over at https://2b90e19c.rescript-lang.pages.dev
✨ Deployment alias URL: https://chore-guide-react-types.rescript-lang.pages.dev

@jderochervlk
jderochervlk merged commit 91dc61e into master Sep 13, 2026
8 checks passed
@jderochervlk
jderochervlk deleted the chore/guide-react-types branch September 13, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants