chore(security): rebind v0.33 advisory evidence to checkout-independent images - #1318
Merged
Merged
Conversation
…nt images The reviewed image bindings pointed at rehearsal run 35711552030, whose BReg executable embedded its own source commit through vendored build scripts. Now that release builds no longer read the checkout git state, rebind all six baselines to rehearsal run 35758336494 so the candidate built from any later commit carries the same reviewed bytes. Only BReg's application layer and executable digest change. The other five images keep every layer and file digest and move only their reference image digest and source revision. Exceptions, expiry dates, review dates and exposure claims are unchanged; the rationales now cite the run and source that were reviewed. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Release security area. Rebinds all six v0.33.0 image advisory baselines to the
review-only evidence from rehearsal run 35758336494 at source
82c1b813a28d61c322d435ce93c9b022455ddb2b, the firstmainrevision whoserelease builder no longer lets vendored build scripts read the checkout git
state (#1317).
The previous bindings came from rehearsal run 35711552030 at
6a460c2cf,whose BReg executable embedded its own source commit. The candidate built from
125f67b37therefore failed the whole-image fingerprint for all three BRegexceptions even though no compiled input had changed.
What moves
Produced by
registry-release renew-advisory-baselines --write, which onlymoves evidence bindings:
runtime.application_layer_ids[0]eb1c6f6d…->ebeebcbc…,component layer for both libc6 exceptions,
/usr/local/bin/bregdigest61d9835e…->1e951595…, and the dependent definition digests. All otherlayers, the OCI process configuration, and the loader, libc, libm and
libpthread file digests are unchanged.
digest is unchanged. Only
reference_image_digest(the OCI revision labelchanges the manifest) and
reference_source_revisionmove, plus theassertion definition digests that cover them.
release/scripts/test_check_advisory_baselines.py:LIVE_REFERENCE_IMAGE_DIGESTSandLIVE_REFERENCE_SOURCE_REVISION.LIVE_REVIEW_EVALUATION_DATEstays2026-09-22.By hand: each of the 18 rationales now cites run 35758336494 and source
82c1b813ainstead of the superseded run and source. No rationale claim,expires_at(2026-10-06),reviewed_at, or accepted finding changed.Evidence
82c1b813ano staged binary embeds the source commit 82c1b813a…in eachgrep -caFof full and 9-char commit in the extracted/usr/local/bin/bregrenew-advisory-baselines --writerenew-advisory-baselinesdry run0 file(s) would changepython3 -m unittest release/scripts/test_check_advisory_baselines.pyrequires a Linux glibc toolchain, macOS host; runs in CI)ns_printrr*,ns_sprintrr*,fp_nquery,strfmon*,libz.soorgz*symbols; the one review-required entry is still an address-takendlsymvia GOT besideINTEL_JIT_PROFILER64andNotifyEventdlsymPLT tail jump each (SQLite extension wrapper)The convergence proof is the next candidate: its BReg application layer must
equal
ebeebcbc…, which it can only do if the build is now commit-independent.Notes
Security baseline change; needs explicit review. It accepts no new
vulnerability and extends no expiry. It only rebinds existing, already reviewed
risk acceptances to images that differ from the previously reviewed ones solely
in the BReg executable, whose change is the removal of two embedded commit
strings.
DCO
Signed-off-bytrailer.