Internalize argocd operator fr clean test - #1292
Closed
olivergondza wants to merge 1317 commits into
Closed
olivergondza wants to merge 1317 commits into
olivergondza wants to merge 1317 commits into
Conversation
…when HA enabled cluster has Only 3 worker nodes (#1933) * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> --------- Signed-off-by: akhil nittala <nakhil@redhat.com>
…ild (#1911) Bumps ubi8/ubi-minimal from `58b1dc5` to `951ee3c`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 951ee3cabb74246821ae31c2b808b7789310f5509882c153b7b178aaaeefa2d3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…938) * Documentation for support of notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * Minor grammatical fix: use proper abbreviation formatting. Signed-off-by: nmirasch <neus.miras@gmail.com> * Removed extra content Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com>
* Add testing for support notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * NotificationController ClusterRole reconciliation added Signed-off-by: nmirasch <neus.miras@gmail.com> * Avoid printing error when skipping reconciliation of resources regarding the target namespace is not enabled Signed-off-by: nmirasch <neus.miras@gmail.com> * Add checks Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * changed test description Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com> Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
* add namespace validation for notification resources Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix e2e test Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* fix: namespace validation for sourcenamespace Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com> * fix: namespace validation for sourcenamespace Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com> * fix: namespace validation for sourcenamespace Signed-off-by: Jonathan West <jgwest@gmail.com> * fix: namespace validation for sourcenamespace Signed-off-by: Jonathan West <jgwest@gmail.com> --------- Signed-off-by: Jayendra Parsai <jparsai@redhat.com> Signed-off-by: Jonathan West <jgwest@gmail.com> Co-authored-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
…cleanup (#1978) Signed-off-by: nmirasch <neus.miras@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
…(#1987) Bumps [pymdown-extensions](https://github.com/facelessuser/pymdown-extensions) from 10.2.1 to 10.16.1. - [Release notes](https://github.com/facelessuser/pymdown-extensions/releases) - [Commits](facelessuser/pymdown-extensions@10.2.1...10.16.1) --- updated-dependencies: - dependency-name: pymdown-extensions dependency-version: 10.16.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ild (#1969) Bumps ubi8/ubi-minimal from `951ee3c` to `7b6b45d`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 7b6b45dfd09bb032f3cabee6d4789d0e8fa8dd824b01783f301b0fdd43e632f7 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ild (#1992) Bumps ubi8/ubi-minimal from `7b6b45d` to `2139859`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 21398599ff11971e5084dae6f5fb8fd880b4b430b4dc2bc80780916066a9695e dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…upgrade (#1991) Signed-off-by: nmirasch <neus.miras@gmail.com>
* GITOPS-8249- added mapping of timeout.reconciliation to env var Signed-off-by: Alka Kumari <alkumari@redhat.com> * commit for retriggering the pipeline Signed-off-by: Alka Kumari <alkumari@redhat.com> --------- Signed-off-by: Alka Kumari <alkumari@redhat.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
…(#2007) Bumps [github.com/argoproj/argo-cd/v3](https://github.com/argoproj/argo-cd) from 3.2.1 to 3.2.3. - [Release notes](https://github.com/argoproj/argo-cd/releases) - [Changelog](https://github.com/argoproj/argo-cd/blob/master/CHANGELOG.md) - [Commits](argoproj/argo-cd@v3.2.1...v3.2.3) --- updated-dependencies: - dependency-name: github.com/argoproj/argo-cd/v3 dependency-version: 3.2.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.38.0 to 0.40.0. - [Commits](golang/mod@v0.38.0...v0.40.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.40.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: include ca.crt key in auto-generated CA ConfigMap
When tls.ca: {} triggers auto-generation of the CA, the operator now
populates the ConfigMap with both tls.crt and ca.crt keys. This matches
the pattern already used by the CA Secret, which stores the certificate
under both keys via corev1.TLSCertKey and corev1.ServiceAccountRootCAKey.
The ConfigMap update is conditional — existing ConfigMaps are only updated
if the ca.crt key is missing, avoiding unnecessary API calls on subsequent
reconciles.
Fixes:
- argoproj-labs/argocd-operator#147 (Using custom TLS certificates with ArgoCD)
- argoproj-labs/argocd-operator#235 (Changing route termination to reencrypt fails)
- ArthurVardevanyan/HomeLab#508
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* fix: preserve existing ConfigMap data during ca.crt backfill
Add only the missing certificate entries to existing ConfigMaps
instead of replacing the entire Data map, preserving unrelated
existing keys.
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* test: add no-op subtest for CA ConfigMap reconciliation
Verify that reconciliation does not call Update when the ConfigMap
already contains both tls.crt and ca.crt keys, and that data is
preserved unchanged.
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* test: use sentinel values and intercept client.Update in CA ConfigMap tests
- 'updates' subtest: use 'existing-tls' sentinel for tls.crt to verify
it's preserved while ca.crt is added
- 'no-op' subtest: use distinct sentinel values for both keys and
attach update interceptor to the client.Client (not k8sClient)
to properly verify Update is not called
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* fix: gofmt configmap_test.go imports
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
* refactor: move SetControllerReference into create branch
Only set owner reference when creating a new ConfigMap, avoiding wasted
work on the existing ConfigMap path.
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
---------
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
…crets without operator label (#2317) Signed-off-by: Rizwana777 <rizwananaaz177@gmail.com>
* feat: add script to pull and update gitops promoter dependencies and add gitops promoter crds Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add rbac for gitops promoter controller manager Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add controller configuration for gitops promoter controller manager Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add deployment for gitops promoter controller Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: allow for creating and patching events in role for promoter and change component name to promoter-controller-manager to be more specific Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add all regular rbac for gitops promoter api server Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add auth rolebinding and clusterrolebinding for gitops promoter Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add apiserver deployment Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add service and apiservice for the apiserver Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add secret ref based tls for apiserver Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add webhook service for promoter controller Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: clean up controller configurations and api services when resource is deleted Signed-off-by: Christopher Coco <ccoco@redhat.com> * refactor: refactor policy rule funcitons to not have an inlined struct Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add gitops promoter argo cd ui extension to the deployment reconcilation for argocd server Signed-off-by: Christopher Coco <ccoco@redhat.com> * feat: add ability to reconcile custom roles Signed-off-by: Christopher Coco <ccoco@redhat.com> * test(unit): unit tests part 1 - service account, controller configuration, api service, and service Signed-off-by: Christopher Coco <ccoco@redhat.com> * test(unit): unit tests part 2 - policy rules, cluster roles, roles, cluster role bindings, and role bindings Signed-off-by: Christopher Coco <ccoco@redhat.com> * test(unit): unit tests part 3 - deployments Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: fix reconcilation loop issues on deployment Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: make service reconcilation happen on type change Signed-off-by: Christopher Coco <ccoco@redhat.com> * test(e2e): add e2e tests for the promoter and refactor agent fixture to extract the cert creation to a shared util Signed-off-by: Christopher Coco <ccoco@redhat.com> * chore: add comments onto all of the functions for the promoter Signed-off-by: Christopher Coco <ccoco@redhat.com> * chore: update to v0.35.0 of the promoter Signed-off-by: Christopher Coco <ccoco@redhat.com> * chore: add updated bundles Signed-off-by: Christopher Coco <ccoco@redhat.com> * chore: add updated bundles again Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: fix lint Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: make webhook its own object Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: coderabbit feedback Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: run update-dependencies Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: lint Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: fix lint errors for real Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: adjust e2e tests and add e2e test for promoter argocd extension Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: change to random namespace for e2e tests for the promoter Signed-off-by: Christopher Coco <ccoco@redhat.com> * ci: rerun Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: move gitops promoter e2e tests to sequential due to APIService Signed-off-by: Christopher Coco <ccoco@redhat.com> * ci: rerun Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: increase timeout on image updater e2e test Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: address feedback Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: generate bundles and add promoter e2e test ns to cluster scoped env for start-e2e Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: remove extra quotation on the makefile edit Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: increase timeout for failing test Signed-off-by: Christopher Coco <ccoco@redhat.com> * docs: add usage page for the promoter Signed-off-by: Christopher Coco <ccoco@redhat.com> * fix: address issue with extension env variable Signed-off-by: Christopher Coco <ccoco@redhat.com> --------- Signed-off-by: Christopher Coco <ccoco@redhat.com>
…ces (#2331) * feat: propagate labeled image pull secrets to ArgoCD namespaces Secrets in the operator namespace with label 'operator.argoproj.io/propagate-image-pull-secret' are copied to all ArgoCD instance namespaces and referenced as imagePullSecrets on every ArgoCD service account (including agent SAs). assisted-by: claude-code Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * add a watcher to trigger secret propagation if secret and not wait for argocd reconciliation Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * feat: Add repo-server sa Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: log and skip when multiple image pull secrets have propagation label Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * update comment Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix(secret): run stale-copy cleanup even when multiple pull secrets labeled Early return on >1 labeled secrets skipped cleanup, orphaning previously-copied secrets. Also add owner-ref filtering on getImagePullSecretRefs and GenericFunc to predicate. assisted-by claude-code Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * add e2e tests Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: shift watcher after inspect cluster Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: failing to get operatorNS should return early (adress review comment) Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * Feat: add secret propagation for gitops promoter Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * Feat: fail early if error fetching operator Names, add default for ARGOCD_OPERATOR_NAMESPACE to argocd for unit test, update unit test Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * add more e2e tests for pull-secret propagation, move test to sequential, update makefile to use ARGOCD_OPERATOR_NAMESPACE with argocd Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix error Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: increase timout from 100m to 110m due to increased in number of tests Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * chore: fix parallel test to sequential test bucket move Signed-off-by: Jonathan West <jgwest@gmail.com> --------- Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> Signed-off-by: Jonathan West <jgwest@gmail.com> Co-authored-by: Jonathan West <jgwest@gmail.com>
…rom 2.45.0 to 2.45.1 (#2353) Signed-off-by: Cheng Fang <cfang@redhat.com>
* fix: skip SA imagePullSecrets management on OpenShift assisted-by: cursor Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: missin guards for image updater and applicationset assisted-by: claude Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: lint error Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: Normalize empty imagePullSecrets before comparison Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix: skip redundant imagePullSecrets update after SA creation Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * trigger commit Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> --------- Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.42.1 to 1.43.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.42.1...v1.43.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-version: 1.43.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Setup argocd-operator 0.20.0 Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Use expected controller-gen version Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.55.0 to 0.56.0. - [Commits](golang/crypto@v0.55.0...v0.56.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.56.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…53b88ef2c5fb2aa143cd4b4b539 Merge remote-tracking branch 'intern' into internalize-argocd-operator-fr Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…ources Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
This reverts commit 2d3be52.
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…ading the kubernetes.io token Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…into internalize-argocd-operator-fr Signed-off-by: Oliver Gondža <ogondza@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Important Review skippedToo many files! This PR contains 1074 files, which is 774 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (1074)
You can disable this status message by setting the Use the checkbox below for a quick retry:
|
|
@olivergondza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run test clean because openshift-ci in #1286 run into a funny state.
Do not merge.