[TypeDeclaration] Skip TypedPropertyFromStrictConstructorRector on protected property redeclared in child class - #8503
Merged
Conversation
…otected property redeclared in child class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9899
When a parent class assigns a protected property in its constructor, the rule typed it, but a child class that redeclares the same property and only delegates via
parent::__construct()was left untyped. This produced a fatal error:A protected property on a non-final class can be redeclared untyped in a child, so typing only the parent breaks covariance. The guard now runs the stricter check for protected properties - they are typed only when the class is final (no child can redeclare). Public and private properties keep their current behavior.