[Php80] Add TernaryToNullsafeCoalesceRector - #8499
Merged
TomasVotruba merged 2 commits intoSep 16, 2026
Merged
TomasVotruba merged 2 commits into
TomasVotruba merged 2 commits into
Conversation
samsonasik
reviewed
Sep 16, 2026
Member
|
Lets ship it, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns a null-check ternary around a method call or property fetch into the nullsafe operator:
TernaryToNullCoalescingRectordoesn't catch this one, it only fires when the if-branch is the very same node as the checked expression.A few notes:
nullfallback needs no??at all:$a !== null ? $a->getB() : nullbecomes$a?->getB()??would swallow it. Guarded withTypeCombinator::containsNull()?->, the rest short-circuits by itselfnull !== $d ? strtoupper($d->format('D')) : ''are skippedNullsafeOperatorRectorwas removed in #900 for loosening types. That one wasif-based and had no check on the return type, this is expression-only and bails out as soon as the call can be null.