[TypeDeclaration] Add BoolReturnTypeFromBooleanConstAndStrictReturnsRector for mixed const + strict bool returns - #8498
Merged
Conversation
…ector for mixed const + strict bool returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds return type
: boolto methods that mix directtrue/falseconst returns with strict bool expression returns - a case that fell between two existing rules.The gap
BoolReturnTypeFromBooleanConstReturnsRectorfires only when all returns aretrue/falseconst.BoolReturnTypeFromBooleanStrictReturnsRectorfires only when all returns are strict bool expressions.A method mixing both kinds matched neither, so no
: boolwas added.This rule
Fires only when every return is bool and at least one is a const while at least one is a strict expression. Pure-const and pure-strict stay owned by the existing rules, so the three rules are disjoint and idempotent on each other's output.
Registered in
TypeDeclarationLevelright after the strict-returns rule.