build(deps): Bump the angular group across 1 directory with 12 updates - #161
Closed
dependabot[bot] wants to merge 4 commits into
Closed
dependabot[bot] wants to merge 4 commits into
dependabot[bot] wants to merge 4 commits into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/angular-ebb3ed1a4b
branch
2 times, most recently
from
September 7, 2026 23:19
445e9f0 to
d108df9
Compare
Bumps the angular group with 11 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@angular/common](https://github.com/angular/angular/tree/HEAD/packages/common) | `21.2.20` | `21.2.22` | | [@angular/compiler](https://github.com/angular/angular/tree/HEAD/packages/compiler) | `21.2.20` | `21.2.22` | | [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) | `21.2.20` | `21.2.22` | | [@angular/elements](https://github.com/angular/angular/tree/HEAD/packages/elements) | `21.2.20` | `21.2.22` | | [@angular/forms](https://github.com/angular/angular/tree/HEAD/packages/forms) | `21.2.20` | `21.2.22` | | [@angular/localize](https://github.com/angular/angular) | `21.2.20` | `21.2.22` | | [@angular/platform-browser](https://github.com/angular/angular/tree/HEAD/packages/platform-browser) | `21.2.20` | `21.2.22` | | [@angular/router](https://github.com/angular/angular/tree/HEAD/packages/router) | `21.2.20` | `21.2.22` | | [@angular/ssr](https://github.com/angular/angular-cli) | `21.2.21` | `21.2.23` | | [@angular-devkit/build-angular](https://github.com/angular/angular-cli) | `21.2.21` | `21.2.23` | | [@angular/cli](https://github.com/angular/angular-cli) | `21.2.21` | `21.2.23` | Updates `@angular/common` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/common) Updates `@angular/compiler` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/compiler) Updates `@angular/core` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/core) Updates `@angular/elements` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/elements) Updates `@angular/forms` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/forms) Updates `@angular/localize` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](angular/angular@v21.2.20...v21.2.22) Updates `@angular/platform-browser` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/platform-browser) Updates `@angular/router` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/router) Updates `@angular/ssr` from 21.2.21 to 21.2.23 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@v21.2.21...v21.2.23) Updates `@angular-devkit/build-angular` from 21.2.21 to 21.2.23 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@v21.2.21...v21.2.23) Updates `@angular/cli` from 21.2.21 to 21.2.23 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@v21.2.21...v21.2.23) Updates `@angular/compiler-cli` from 21.2.20 to 21.2.22 - [Release notes](https://github.com/angular/angular/releases) - [Changelog](https://github.com/angular/angular/blob/v21.2.22/CHANGELOG.md) - [Commits](https://github.com/angular/angular/commits/v21.2.22/packages/compiler-cli) --- updated-dependencies: - dependency-name: "@angular-devkit/build-angular" dependency-version: 21.2.22 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/cli" dependency-version: 21.2.22 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/common" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/compiler" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/compiler-cli" dependency-version: 21.2.22 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/core" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/elements" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/forms" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/localize" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/platform-browser" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/router" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular - dependency-name: "@angular/ssr" dependency-version: 21.2.22 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: angular ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/angular-ebb3ed1a4b
branch
from
September 10, 2026 18:58
d108df9 to
921e5bc
Compare
adamjohnwright
enabled auto-merge (squash)
September 10, 2026 20:22
Contributor
|
@dependabot rebase |
Contributor
Author
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Contributor
|
This cannot be merged as it stands, and the green checks are misleading. The group bumps 11 Angular packages from 21.2.20 to 21.2.22 but leaves The checks pass only because CI installs with It is a regression, not a pre-existing state: main resolves strictly today Fixing it properly means moving the whole framework train together — core, The other five open bumps have been taken in #214. Leaving this one open. |
This was referenced Sep 16, 2026
adamjohnwright
added a commit
that referenced
this pull request
Sep 17, 2026
Two fixes, and the second explains why this branch failed CI all day. **The Angular train moves together.** Dependabot's #161 bumps eleven packages and leaves `platform-browser-dynamic` and `compiler-cli` behind; Angular's packages peer-depend at exact versions, so that set cannot resolve. Core, common, compiler, compiler-cli, forms, router, elements, localize, platform-browser and platform-browser-dynamic all go to 21.2.23, and the CLI train with them. **The lockfile is regenerated under Node 22, which is what CI runs.** I generated the first one on Node 24 / npm 11, and npm 10 rejected it: EBADPLATFORM lightningcss-android-arm64 wanted os "android", got linux npm 11 records optional platform packages in a shape npm 10 tries to install. Regenerated with `node:22` in docker, the android entries are `optional: true, os: ["android"]` and `npm ci` adds 2212 packages cleanly. `engines` is tightened from `>=22` to `22.x` so this cannot recur silently. `.nvmrc` has said 22 all along and CI has always used it; only `engines` was permissive enough to let a lockfile be written by the wrong npm. CONTRIBUTING records both failure signatures, because each looks like a dependency problem rather than a version problem. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
adamjohnwright
added a commit
that referenced
this pull request
Sep 17, 2026
* chore(deps): move the whole Angular train to 21.2.23 Replaces dependabot's #161, which cannot be merged as it stands. That PR moves eleven Angular packages from 21.2.20 to 21.2.22 and leaves `@angular/platform-browser-dynamic` and `@angular/compiler-cli` behind. Angular's packages peer-depend on one another at **exact** versions, so the result does not resolve: Conflicting peer dependency: @angular/core@21.2.23 peer @angular/core@"21.2.23" from @angular/platform-browser-dynamic@21.2.23 Its checks pass only because CI installs with `--legacy-peer-deps`, which accepts an inconsistent tree. #215 removes that flag; after it, #161 fails honestly. So the train moves together: core, common, compiler, compiler-cli, forms, router, elements, localize, platform-browser and platform-browser-dynamic to 21.2.23, and the CLI train -- cli, ssr, build-angular -- to its own 21.2.23. The lockfile is regenerated from scratch rather than hand-resolved, because a partially-merged lock is what produced the conflict in the first place. It resolves **strictly**: `npm ci --dry-run` with no `--legacy-peer-deps`. Verified: 242 unit tests, types, lint 652, dead code 145, format, a full build, and 49 e2e cases against the resulting build -- interactors, the threshold, the custom-resource dialog, the homepage, content pages and the back button. The diagram is what an Angular bump would break, so it is what was exercised. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(deps): move the whole Angular train to 21.2.23, on the right npm Two fixes, and the second explains why this branch failed CI all day. **The Angular train moves together.** Dependabot's #161 bumps eleven packages and leaves `platform-browser-dynamic` and `compiler-cli` behind; Angular's packages peer-depend at exact versions, so that set cannot resolve. Core, common, compiler, compiler-cli, forms, router, elements, localize, platform-browser and platform-browser-dynamic all go to 21.2.23, and the CLI train with them. **The lockfile is regenerated under Node 22, which is what CI runs.** I generated the first one on Node 24 / npm 11, and npm 10 rejected it: EBADPLATFORM lightningcss-android-arm64 wanted os "android", got linux npm 11 records optional platform packages in a shape npm 10 tries to install. Regenerated with `node:22` in docker, the android entries are `optional: true, os: ["android"]` and `npm ci` adds 2212 packages cleanly. `engines` is tightened from `>=22` to `22.x` so this cannot recur silently. `.nvmrc` has said 22 all along and CI has always used it; only `engines` was permissive enough to let a lockfile be written by the wrong npm. CONTRIBUTING records both failure signatures, because each looks like a dependency problem rather than a version problem. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore: run on Node 24, the LTS the toolchain already supports `engines` pinned `node: 22.x` and `npm: >=10 <11`, which is why the lockfile and the local machine could not agree: npm 11 records optional platform packages that npm 10 leaves out, so a lockfile generated by either is a desync to the other. The pin was the cause, not the cure. Angular 21 declares `^20.19.0 || ^22.12.0 || >=24.0.0` and 24 is Latest LTS, so this moves engines, `.nvmrc`, all four workflows, both Dockerfiles and the local setup document to 24 together. **No dependency changes versions.** Compared across every path in the tree: 91 packages added, all of them optional platform binaries (@napi-rs/nice, @oxc-parser bindings, @emnapi); 0 removed; 0 that lost a version. Angular stays on 21.2.x throughout. `--legacy-peer-deps` stays, and now with a measured reason. Dropping it needs @analogjs/vitest-angular to move off 2.3.1, and letting npm re-resolve to get there dragged in 207 top-level version changes including React 18 -> 19 and @Angular-devkit 21 -> 22. That is a separate decision, not a side effect of changing Node. Recorded on #215. `scripts/preflight.sh` was running a bare `npm ci --dry-run` while every workflow installs with `--legacy-peer-deps`, so the gate whose whole job is to reproduce CI was running a different command and failing on a peer conflict the real build never sees. It now runs CI's command, and says which Node to run on. Verified: preflight green end to end on Node 24 / npm 11 — lockfile in sync, format, types, lint, dead code, unit tests, and the download smoke. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
auto-merge was automatically disabled
September 17, 2026 04:58
Pull request was closed
Contributor
Author
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/angular-ebb3ed1a4b
branch
September 17, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the angular group with 11 updates in the / directory:
21.2.2021.2.2221.2.2021.2.2221.2.2021.2.2221.2.2021.2.2221.2.2021.2.2221.2.2021.2.2221.2.2021.2.2221.2.2021.2.2221.2.2121.2.2321.2.2121.2.2321.2.2121.2.23Updates
@angular/commonfrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/common's releases.
Changelog
Sourced from @angular/common's changelog.
Commits
Updates
@angular/compilerfrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/compiler's releases.
Changelog
Sourced from @angular/compiler's changelog.
Commits
Updates
@angular/corefrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/core's releases.
Changelog
Sourced from @angular/core's changelog.
Commits
Updates
@angular/elementsfrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/elements's releases.
Changelog
Sourced from @angular/elements's changelog.
Commits
Updates
@angular/formsfrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/forms's releases.
Changelog
Sourced from @angular/forms's changelog.
Commits
Updates
@angular/localizefrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/localize's releases.
Changelog
Sourced from @angular/localize's changelog.
Commits
4c0bc43release: cut the v21.2.22 release5aa6d97fix(platform-server): avoid stripping unicode whitespace during url resolution73d8bbdfix(platform-server): update domino to latest version992d627release: cut the v21.2.21 releasec19a36cfix(platform-browser): disallow event handler attributes in MetaUpdates
@angular/platform-browserfrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/platform-browser's releases.
Changelog
Sourced from @angular/platform-browser's changelog.
Commits
c19a36cfix(platform-browser): disallow event handler attributes in MetaUpdates
@angular/routerfrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/router's releases.
Changelog
Sourced from @angular/router's changelog.
Commits
Updates
@angular/ssrfrom 21.2.21 to 21.2.23Release notes
Sourced from @angular/ssr's releases.
Changelog
Sourced from @angular/ssr's changelog.
... (truncated)
Commits
e2582bbrelease: cut the v21.2.23 release645e41afix(@angular/ssr): ensure public directory containment in CommonEngined3aaa48fix(@angular-devkit/build-angular): update less to 4.9.060dee48release: cut the v21.2.22 releaseb0047b0fix(@angular-devkit/build-angular): update webpack-dev-server to 5.2.6Updates
@angular-devkit/build-angularfrom 21.2.21 to 21.2.23Release notes
Sourced from @angular-devkit/build-angular's releases.
Changelog
Sourced from @angular-devkit/build-angular's changelog.
... (truncated)
Commits
e2582bbrelease: cut the v21.2.23 release645e41afix(@angular/ssr): ensure public directory containment in CommonEngined3aaa48fix(@angular-devkit/build-angular): update less to 4.9.060dee48release: cut the v21.2.22 releaseb0047b0fix(@angular-devkit/build-angular): update webpack-dev-server to 5.2.6Updates
@angular/clifrom 21.2.21 to 21.2.23Release notes
Sourced from @angular/cli's releases.
Changelog
Sourced from @angular/cli's changelog.
... (truncated)
Commits
e2582bbrelease: cut the v21.2.23 release645e41afix(@angular/ssr): ensure public directory containment in CommonEngined3aaa48fix(@angular-devkit/build-angular): update less to 4.9.060dee48release: cut the v21.2.22 releaseb0047b0fix(@angular-devkit/build-angular): update webpack-dev-server to 5.2.6Updates
@angular/compiler-clifrom 21.2.20 to 21.2.22Release notes
Sourced from @angular/compiler-cli's releases.
Changelog
Sourced from @angular/compiler-cli's changelog.
Commits