fix: show default tooltips on focus - #541
Conversation
|
@nrps9909 is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughTooltip 的默认触发方式从仅支持 hover 改为支持 hover 和 focus。新增测试验证焦点时的 Tooltip 内容、 ChangesTooltip 默认焦点触发
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized accessibility change adds focus behavior for default tooltips and reports passing tests, lint, type checks, compilation, and builds; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 36 36
Branches 14 14
=========================================
Hits 36 36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
focusin Tooltip's default trigger actionsaria-describedbyand mount the tooltip when a keyboard user focuses the default triggertriggerconfigurations unchangedCloses #496.
Verification
ba2d690: the focused default trigger had noaria-describedbyand the test failedpnpm lintpnpm tscpnpm compile(ESM/CJS declarations and Less assets)pnpm build(including docs)git diff --checkAI assistance disclosure: Codex was used to trace the existing accessibility history, check for duplicate PRs, implement the focused fix, and run the verification above. The behavior and results were verified locally.
Summary by CodeRabbit