Give the visual editor screenshots real alt text - #2195
Merged
Merged
Conversation
Seven raw <img> tags used fig-alt=, which only Quarto's Markdown image syntax understands. The browser ignored it, so the images had no accessible name. Convert them to Markdown images with an empty caption so they stay plain images, not figures.
Contributor
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2195.quarto.org 🔄 Modified Documents |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven screenshots on the visual editor pages had no accessible name. They used raw
<img>tags withfig-alt=. Only Quarto's Markdown image syntax understandsfig-alt. Pandoc passes raw HTML through unchanged, so the browser ignored the attribute.This PR changes the seven tags to Markdown images. The alt text is the same. The caption is empty, so each image stays a plain image and does not become a figure. The
.illustrationclass and the widths are unchanged.Pages:
docs/visual-editor/options.qmd(3 images)docs/visual-editor/technical.qmd(3 images)docs/tools/_code-oss-visual-editor.md(1 image, included on the VS Code and Positron visual editor pages)A second commit corrects the alt text for the Zotero group library screenshot. The old text had a missing word and a missing closing quote.
Evidence
quarto call axeon the 7 affected pages, before and after, with the same--pages:image-altfindings cleared (both onoptions.html)image-alt :: img[width="*"]went from 13 to 7 instances. The 7 that remain are images with no alt text at all, which a later PR will fix.