Scope test-smokes-built.yml's workflow_run trigger to main - #14923
Merged
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
With no branches filter, any completed create-release.yml run - including manual workflow_dispatch from a non-main branch, a common pattern during packaging/signing work (22 such dispatches in the last 300 runs) - fans out the full built-version smoke/playwright/feature-format-matrix suite across three OSes. Release branches (v1.9, v1.10) are excluded from the filter since they predate the binary-mode test harness added in #14706 and would fail on a missing harness rather than a real defect. The manual escape hatch (dispatching this workflow with source=nightly and an explicit run-id) is unaffected.
cderv
force-pushed
the
fix/test-smokes-built-workflow-run-branch-filter
branch
from
September 23, 2026 13:23
ce9841a to
97680a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing #14706 before merge:
test-smokes-built.yml'sworkflow_runtrigger has nobranchesfilter, so any completedcreate-release.ymlrun fans out the full built-version smoke/playwright/feature-format-matrix suite across three OSes, including manualworkflow_dispatchruns from non-main branches. In the last 300create-release.ymlruns, 22 ran on a non-main branch, several in bursts during packaging/signing work.Fix
Adds
branches: [main]to theworkflow_runtrigger, so only main-branchcreate-release.ymlruns (scheduled or dispatched) trigger the built-version suite. Release branches (v1.9, v1.10) are excluded on purpose: they predate the binary-mode test harness added in #14706, so aworkflow_runon those branches would run main's copy of the workflow against sources missing that harness and fail on every leg, not on a real defect.The manual escape hatch is unaffected: dispatching
test-smokes-built.ymldirectly withsource=nightlyand an explicit run id still works, and doesn't require the upstream run to have succeeded, only that its artifacts are non-expired.Test Plan
actionlint .github/workflows/test-smokes-built.yml— cleancreate-release.ymlfrom a non-main branch, confirm it does not trigger a newtest-smokes-built.ymlrun (checked viagh run listagainst a recorded baseline run id/timestamp)create-release.ymlrun on main still triggerstest-smokes-built.ymlas beforeNo changelog entry, CI-only, not user-visible.