Add skip-auto-smoke opt-out to create-release.yml dispatch - #14911
Merged
Merged
Conversation
A manual create-release dispatch always fans out into the full built-version smoke/Playwright/ff-matrix suite via workflow_run once it completes (D1/D7/D9 in llm-docs/built-version-testing-architecture.md). Sometimes that's not needed (packaging tweak check, partial build) and there was no way to opt out short of a schedule-only gate that would have killed the D7 flow entirely. The Runs API doesn't expose workflow_dispatch inputs on a completed run, so test-smokes-built.yml can't read the flag off github.event.workflow_run directly. Instead, create-release.yml encodes the flag in its run-name, which the completed workflow_run payload carries as display_title -- no extra API call needed, and no artifact upload/download side effect either (an earlier version of this used a marker artifact; dropped because it left durable state that would silently suppress a later manual re-test of that same run). Complementary to the sibling quarto-cli-po9o.9 issue, which gates the same trigger by branch -- kept as a separate, independent mechanism.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-release.yml's manual dispatch always fans out into the full built-version smoke/Playwright/feature-format-matrix suite once the build completes, via a workflow_run listener in test-smokes-built.yml. That's fine for a full release build, but a manual dispatch to check a packaging tweak or run a partial build doesn't always need the downstream suite, and there was no way to opt out short of a schedule-only gate that would have removed the always-test behavior for every manual dispatch, not just the ones that want to skip it.
Adds a skip-auto-smoke boolean input (default false) to create-release.yml's workflow_dispatch.
The Runs API doesn't expose workflow_dispatch inputs on a completed run, so test-smokes-built.yml's resolve-nightly job can't read the flag off github.event.workflow_run directly. create-release.yml instead encodes it in its run-name (
Build Installers [skip-auto-smoke]), which the completed workflow_run payload carries as display_title. resolve-nightly reads that and short-circuits has-linux/has-windows/has-mac to false, so every nightly leg no-ops through its existing gate. Theworkflows: ["Build Installers"]trigger filter matches the workflow's name, not its run-name, so the custom title doesn't affect whether workflow_run fires.An earlier version of this used a marker artifact uploaded alongside the build artifacts instead. That was dropped: it left durable state for the artifact's full retention period, which would have silently suppressed a later manual re-test of that same run via test-smokes-built.yml's own run-id input. The run-name approach is scoped to the workflow_run event only, so an explicit manual re-test still runs.
Test Plan
Build Installers [skip-auto-smoke]