Skip to content

NXP backend: Fix NeutronConfig copy callback signature to match the d… #22439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jirioc wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

NXP backend: Fix NeutronConfig copy callback signature to match the d… #22439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,7 +1716,7 @@ jobs:
conda activate "${CONDA_ENV}"

# Build
cmake -DEXECUTORCH_BUILD_NXP_NEUTRON=ON -Bcmake-out .
cmake -DEXECUTORCH_BUILD_NXP_NEUTRON=ON -DCMAKE_CXX_FLAGS="-DEXTERNAL_MEM" -Bcmake-out .

@robert-kalmar robert-kalmar Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of editing the CMAKE_CXX_FLAGS, introduce a configuration option into Neutron Backend, allowing the External Memory for eIQ Neutron NPU.

cmake --build cmake-out --target executorch_delegate_neutron --config Release

# Build check for the neutron backend library
Expand Down
3 changes: 2 additions & 1 deletion backends/nxp/runtime/NeutronBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ typedef struct {
// Neutron compute has no access to FLASH.
// Prefetch weights from FLASH to SRAM using memcpy.
// For a model converted with --fetch_constants_to_sram.
void copy(void* dst, const void* src, uint32_t size, uint32_t channel) {
// cppcheck-suppress constParameterCallback
void copy(void* dst, void* src, uint32_t size, uint32_t channel) {

@robert-kalmar robert-kalmar Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

void copy(void* dst, const void* src, uint32_t size, uint32_t channels)

shall avoid the CPPCHECK reported issue.

@jirioc jirioc Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Const needs to be removed in order to be compatible with the NeutronDriver.h

memcpy(dst, src, size);
}
void wait(uint32_t channel) {}
Expand Down
Loading