gh-156635: Fix the exceptions in the xml.dom documentation - #156636
Merged
serhiy-storchaka merged 1 commit intoAug 30, 2026
Conversation
Node.insertBefore(), Node.removeChild() and Node.replaceChild() raise NotFoundErr, not ValueError. Element.removeAttribute() and Element.removeAttributeNS() raise NotFoundErr if there is no matching attribute, which contradicts the DOM, so this is documented as a deviation in the minidom documentation.
serhiy-storchaka
added
needs backport to 3.13
Documentation build overview
|
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-156637 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-156638 is a backport of this pull request to the 3.14 branch. |
|
GH-156639 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 30, 2026
…-156636) (GH-156638) Node.insertBefore(), Node.removeChild() and Node.replaceChild() raise NotFoundErr, not ValueError. Element.removeAttribute() and Element.removeAttributeNS() raise NotFoundErr if there is no matching attribute, which contradicts the DOM, so this is documented as a deviation in the minidom documentation. (cherry picked from commit 74b944a) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 30, 2026
…-156636) (GH-156639) Node.insertBefore(), Node.removeChild() and Node.replaceChild() raise NotFoundErr, not ValueError. Element.removeAttribute() and Element.removeAttributeNS() raise NotFoundErr if there is no matching attribute, which contradicts the DOM, so this is documented as a deviation in the minidom documentation. (cherry picked from commit 74b944a)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 30, 2026
The DOM does not allow Element.removeAttribute() and removeAttributeNS() to raise NotFoundErr in this case, it is a deviation of minidom, documented in pythonGH-156636.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.insertBefore(),Node.removeChild()andNode.replaceChild()were documented as raisingValueErrorfor a node which is not a child of this node. They raiseNotFoundErr, which is aDOMExceptionand not aValueError.Element.removeAttribute()was documented as raisingNotFoundErrif there is no matching attribute, andElement.removeAttributeNS()as raising nothing, although both raiseNotFoundErr. The DOM specifies that removing an absent attribute has no effect, so neither is documented inxml.domany more, and this is documented as a deviation in thexml.dom.minidomdocumentation.xml.domdocuments wrong exceptions for some methods #156635