gh-155193: Fix the *canonical* decoder lists in the 3.15 What's New and NEWS - #156302
Conversation
…in What's New 3.15
Documentation build overview
|
|
Can you check if a NEWS entry needs to be amended as well? |
|
The NEWS entry doesn't name Separately, the binascii bullet in What's New only lists |
|
Nah for What's New it's ok. |
gpshead
left a comment
There was a problem hiding this comment.
good catch on base16 being errantly listed as well.
|
@AA-Turner is this good to be merged? |
|
Thanks @advitrocks9 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-156370 is a backport of this pull request to the 3.15 branch. |
The 3.15 What's New lists
urlsafe_b64decode()as one of the decoders that got canonical, but it never got the parameter:It doesn't call
b64decode(), it callsbinascii.a2b_base64()directly with a fixed set of arguments, so wideningb64decode()in GH-146312 didn't affect it. This drops it from the bullet, per gpshead on the issue.I went through the other bullets in the base64 section and checked them against the signatures. This is the only one that's off.
The NEWS entry for the same change (now in
Misc/NEWS.d/3.15.0b1.rst) says the base16 decoders got canonical, but none did:b16decode()andbinascii.a2b_hex()are unchanged. Removed base16 from that entry too.Docs only, so
skip news. Needs a backport to 3.15.base64module #155193