gh-130647: Add --omit-header option to pygettext

[StanFromIreland]

Requesting @tomasr8 :-)

• Issue: pygettext: Add --omit-header option #130647

[StanFromIreland]

Also @serhiy-storchaka

[StanFromIreland]

Anything else left to do here @tomasr8 ?

[tomasr8]

LGTM

[StanFromIreland]

Little reminder @serhiy-storchaka

[serhiy-storchaka]

Please use non-ASCII strings and non-UTF-8 source encoding for tests. The encoding should also be different from Latin1. Maybe iso-8859-15 with € in a string. Use both literal € and \u20ac (in different strings, so the error will be easier to identify).

[StanFromIreland]

Please use non-ASCII strings and non-UTF-8 source encoding for tests.

Might I ask why? The implementation does effect anything beyond the header, it is literally a single if statement. The file is generated so we can verify whitespace, at Tomas's request.

[serhiy-storchaka]

Why to add this feature at first place? If it is for tests, we should ensure that it works with non-ASCII strings. Otherwise this option will be useless.

We need also tests with non-ASCII strings for gettext and pygettext, but this is a different issue.

[StanFromIreland]

Why to add this feature at first place?

See the linked issue, this was discussed before.

we should ensure that it works with non-ASCII strings.

This feature just removes the POT header.

[StanFromIreland]

Friendly ping @serhiy-storchaka :-)

[serhiy-storchaka]

The problem with this feature is that we are losing information about the .po file encoding, which is locale depending. Therefore, files generated on different computers may be incompatible. There is an issue with using the default file encoding in general, because it may be not compatible with the source file encoding (msgids and comments) and filesystem encoding (file names).

We can probably just ignore this for now. And then somehow solve all the encoding problems at once.

But adding a feature that contains an inherent flaw leaves a bitter aftertaste.

[StanFromIreland]

Friendly ping @serhiy-storchaka / @tomasr8

[StanFromIreland]

@serhiy-storchaka, anything else I should do here?

[github-actions]

This PR is stale because it has been open for 30 days with no activity.

[serhiy-storchaka]

@StanFromIreland, you can merge this PR yourself.