Skip to content

Fix some "ruff check" warnings - #787

Open
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:ruff
Open

Fix some "ruff check" warnings#787
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:ruff

Conversation

@vstinner

@vstinner vstinner commented Sep 7, 2026

Copy link
Copy Markdown
Member

Remove unused import and variables.

Remove unused import and variables.

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We could add these Ruff checks to a CI lint as a followup to prevent new ones slipping in?

@StanFromIreland

Copy link
Copy Markdown
Member

We could add these Ruff checks to a CI lint as a followup to prevent new ones slipping in?

I'd support adding pre-commit with a ruff hook (and possibly a few others, like trailing whitespace or zizmor).

@encukou

encukou commented Sep 7, 2026

Copy link
Copy Markdown
Member

In my opinion, this is a textbook example of unnecessary churn.

@vstinner

vstinner commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

I would like to fix these warnings to be able to run ruff check manually time to time to check for real bugs. Currently, the output is too verbose to be useful (because of the fixed issues).

@StanFromIreland

Copy link
Copy Markdown
Member

I think adding specific ignores is worse than a little churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants