Simplify MathMixin.random_choice() - #797
Open
ulgens wants to merge 2 commits into
Open
Conversation
This was referenced Aug 26, 2026
Removes redundant Java-style index based approach. This was the original approach with .random_choice(), but the code move away from it in f8076aa without any explanation.
ulgens
force-pushed
the
simplify-random_choice
branch
from
August 28, 2026 16:42
7715553 to
68dbb1c
Compare
ulgens
added a commit
to ulgens/py5
that referenced
this pull request
Aug 28, 2026
Relates to: - #2 - py5coding/py5generator#797
ulgens
added a commit
to ulgens/py5
that referenced
this pull request
Aug 28, 2026
Relates to: - #2 - py5coding/py5generator#797
ulgens
added a commit
to ulgens/py5
that referenced
this pull request
Aug 28, 2026
Relates to: - #2 - py5coding/py5generator#797
ulgens
added a commit
to ulgens/py5
that referenced
this pull request
Aug 28, 2026
Relates to: - #2 - py5coding/py5generator#797
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes redundant Java-style index based approach.
This was the original approach with .random_choice(), but the code move away from it in f8076aa without any explanation.